Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: chrome/BUILD.gn

Issue 2752463003: Dump and archive symbols for AlertNotificationService.xpc. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 5604ed63ea9f53eca6642d5fdf34ed6b6a26a2ab..2eed73161fc9a6374cc106fe9007e474a51b5b2d 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -1179,6 +1179,10 @@ if (is_win) {
"$root_out_dir/crashpad_handler",
]
+ if (enable_xpc_notifications) {
+ _chrome_symbols_sources += [ "$root_out_dir/AlertNotificationService.xpc/Contents/MacOS/AlertNotificationService" ]
+ }
+
# It is possible to run dump_syms on unstripped products without dSYMs,
# but doing so isn't logical and won't happen in practice.
action_foreach("chrome_dump_syms") {
@@ -1207,6 +1211,10 @@ if (is_win) {
"//breakpad:dump_syms",
"//third_party/crashpad/crashpad/handler:crashpad_handler",
]
+
+ if (enable_xpc_notifications) {
+ deps += [ "//chrome/browser/ui/cocoa/notifications:alert_notification_xpc_service" ]
+ }
}
action("chrome_dsym_archive") {
@@ -1223,6 +1231,10 @@ if (is_win) {
"$root_out_dir/crashpad_handler.dSYM",
]
+ if (enable_xpc_notifications) {
+ _dsyms += [ "$root_out_dir/AlertNotificationService.dSYM" ]
+ }
+
sources = _chrome_symbols_sources
_output = "$root_out_dir/$chrome_product_full_name.dSYM.tar.bz2"
@@ -1240,6 +1252,10 @@ if (is_win) {
":chrome_helper_app",
"//third_party/crashpad/crashpad/handler:crashpad_handler",
]
+
+ if (enable_xpc_notifications) {
+ deps += [ "//chrome/browser/ui/cocoa/notifications:alert_notification_xpc_service" ]
+ }
}
} else {
group("chrome_dump_syms") {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698