Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2752433002: [Mac] Fix a crash in handling keyboard shortcuts for empty bookmark folder menus. (Closed)

Created:
3 years, 9 months ago by Robert Sesek
Modified:
3 years, 9 months ago
Reviewers:
lgrey, Elly Fong-Jones
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix a crash in handling keyboard shortcuts for empty bookmark folder menus. Empty bookmark bar folder menus have an "(empty)" button that is not associated with an actual model node. This leads to a DCHECK in the BookmarkBarController, but crashes in release mode. BUG=690424 Review-Url: https://codereview.chromium.org/2752433002 Cr-Commit-Position: refs/heads/master@{#456460} Committed: https://chromium.googlesource.com/chromium/src/+/8da61374a11432c3b6c3acf43d50d562439dba02

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
Robert Sesek
3 years, 9 months ago (2017-03-13 18:53:45 UTC) #6
lgrey
LGTM
3 years, 9 months ago (2017-03-13 18:56:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752433002/1
3 years, 9 months ago (2017-03-13 19:25:24 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-03-13 19:25:26 UTC) #11
Robert Sesek
3 years, 9 months ago (2017-03-13 19:28:06 UTC) #13
Elly Fong-Jones
lgtm
3 years, 9 months ago (2017-03-13 20:14:08 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752433002/1
3 years, 9 months ago (2017-03-13 20:15:37 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 20:22:59 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8da61374a11432c3b6c3acf43d50...

Powered by Google App Engine
This is Rietveld 408576698