Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4932)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm

Issue 2752433002: [Mac] Fix a crash in handling keyboard shortcuts for empty bookmark folder menus. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm
index e55534324f568ddaa93ccd0eca5354c186ccf826..1a85e0406a3db0529efa2067f7e1b57665ba2e26 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm
@@ -1393,6 +1393,31 @@ TEST_F(BookmarkBarFolderControllerMenuTest, HoverThenDeleteBookmark) {
EXPECT_FALSE(buttonThatMouseIsIn);
}
+// Tests that sending keyboard events to the (empty) button in an empty
+// folder menu does not crash. https://crbug.com/690424
+TEST_F(BookmarkBarFolderControllerMenuTest, ActOnEmptyMenu) {
+ BookmarkModel* model = BookmarkModelFactory::GetForBrowserContext(profile());
+ const BookmarkNode* root = model->bookmark_bar_node();
+ const BookmarkNode* folder =
+ model->AddFolder(root, root->child_count(), ASCIIToUTF16("empty"));
+ ASSERT_TRUE(folder);
+
+ BookmarkButton* button = [bar_ buttonWithTitleEqualTo:@"empty"];
+ [[button target] performSelector:@selector(openBookmarkFolderFromButton:)
+ withObject:button];
+
+ BookmarkBarFolderController* bbfc = [bar_ folderController];
+ NSArray* buttons = [bbfc buttons];
+ ASSERT_EQ(1u, [buttons count]);
+
+ button = [buttons objectAtIndex:0];
+ EXPECT_TRUE([button isEmpty]);
+
+ [bbfc mouseEnteredButton:button event:nil];
+
+ EXPECT_TRUE([bbfc handleInputText:@" "]);
+}
+
// Just like a BookmarkBarFolderController but intercedes when providing
// pasteboard drag data.
@interface BookmarkBarFolderControllerDragData : BookmarkBarFolderController {
« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698