third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js - Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js

Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense (Closed)

Patch Set: review comments addressed Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/Tests.js ('k') | third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js b/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js

index 8940d93719268e70ee98a09a5be1a80838eddeaa..7f5ac4bd1d0eaf8301eb13c8b8c6e1990679ceb7 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js

@@ -200,8 +200,7 @@ Bindings.DebuggerWorkspaceBinding = class extends Common.Object {

var target = Bindings.NetworkProject.targetForUISourceCode(uiLocation.uiSourceCode);

if (target) {

var rawLocation = this.uiLocationToRawLocation(

- SDK.DebuggerModel.fromTarget(target), uiLocation.uiSourceCode, uiLocation.lineNumber,

- uiLocation.columnNumber);

+ target.model(SDK.DebuggerModel), uiLocation.uiSourceCode, uiLocation.lineNumber, uiLocation.columnNumber);

if (rawLocation)

return this.rawLocationToUILocation(rawLocation);

}