Chromium Code Reviews
Help | Chromium Project | Sign in
(151)

Issue 2752293002: named_caches: make more resilient to corrupted state

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 days, 23 hours ago by nodir
Modified:
2 days, 16 hours ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

named_caches: make more resilient to corrupted state A state file may be corrupted. Make CacheManager.open() purge cache dir if so. R=maruel@chromium.org BUG=702159

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M client/named_cache.py View 1 1 chunk +9 lines, -4 lines 3 comments Download
M client/tests/named_cache_test.py View 2 chunks +10 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 9 (3 generated)
nodir
PTAL This does not address individual AIs in crbug.com/702159, but solves the underlying problem.
6 days, 23 hours ago (2017-03-16 16:52:21 UTC) #2
M-A Ruel
https://codereview.chromium.org/2752293002/diff/20001/client/named_cache.py File client/named_cache.py (right): https://codereview.chromium.org/2752293002/diff/20001/client/named_cache.py#newcode75 client/named_cache.py:75: file_path.rmtree(self.root_dir) nit: I'd prefer the directory itself to not ...
6 days, 2 hours ago (2017-03-17 13:43:41 UTC) #3
nodir
https://codereview.chromium.org/2752293002/diff/20001/client/named_cache.py File client/named_cache.py (right): https://codereview.chromium.org/2752293002/diff/20001/client/named_cache.py#newcode75 client/named_cache.py:75: file_path.rmtree(self.root_dir) On 2017/03/17 13:43:41, M-A Ruel wrote: > nit: ...
5 days, 23 hours ago (2017-03-17 16:20:57 UTC) #4
M-A Ruel
https://codereview.chromium.org/2752293002/diff/20001/client/named_cache.py File client/named_cache.py (right): https://codereview.chromium.org/2752293002/diff/20001/client/named_cache.py#newcode75 client/named_cache.py:75: file_path.rmtree(self.root_dir) On 2017/03/17 16:20:56, nodir wrote: > On 2017/03/17 ...
2 days, 16 hours ago (2017-03-20 23:22:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752293002/20001
2 days, 16 hours ago (2017-03-20 23:24:04 UTC) #7
commit-bot: I haz the power
2 days, 16 hours ago (2017-03-20 23:57:12 UTC) #9
Try jobs failed on following builders:
  Luci-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/3506f69ef8125010)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d1a128a62