Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2752293002:
named_caches: make more resilient to corrupted state (Closed)
Descriptionnamed_caches: make more resilient to corrupted state
A state file may be corrupted. Make CacheManager.open() purge cache dir
if so.
R=maruel@chromium.org
BUG=702159
Review-Url: https://codereview.chromium.org/2752293002
Committed: https://github.com/luci/luci-py/commit/c497fefe848a225036b03dc7b44454c0c16a55d3
Patch Set 1 #Patch Set 2 : nit #
Total comments: 3
Patch Set 3 : lint #
Messages
Total messages: 20 (9 generated)
Description was changed from ========== named_caches: make more resilient to corrupted state A state file may be corrupted. Make CacheManager.open() purge cache dir if so. R=maruel@chromium.org BUG= ========== to ========== named_caches: make more resilient to corrupted state A state file may be corrupted. Make CacheManager.open() purge cache dir if so. R=maruel@chromium.org BUG=702159 ==========
PTAL This does not address individual AIs in crbug.com/702159, but solves the underlying problem.
https://codereview.chromium.org/2752293002/diff/20001/client/named_cache.py File client/named_cache.py (right): https://codereview.chromium.org/2752293002/diff/20001/client/named_cache.py#n... client/named_cache.py:75: file_path.rmtree(self.root_dir) nit: I'd prefer the directory itself to not be deleted but as a quick fix, lgtm
https://codereview.chromium.org/2752293002/diff/20001/client/named_cache.py File client/named_cache.py (right): https://codereview.chromium.org/2752293002/diff/20001/client/named_cache.py#n... client/named_cache.py:75: file_path.rmtree(self.root_dir) On 2017/03/17 13:43:41, M-A Ruel wrote: > nit: I'd prefer the directory itself to not be deleted but as a quick fix, lgtm why? CacheManager works fine if the directory doesn't exist.
https://codereview.chromium.org/2752293002/diff/20001/client/named_cache.py File client/named_cache.py (right): https://codereview.chromium.org/2752293002/diff/20001/client/named_cache.py#n... client/named_cache.py:75: file_path.rmtree(self.root_dir) On 2017/03/17 16:20:56, nodir wrote: > On 2017/03/17 13:43:41, M-A Ruel wrote: > > nit: I'd prefer the directory itself to not be deleted but as a quick fix, > lgtm > > why? CacheManager works fine if the directory doesn't exist. I don't know, it's a feeling about simplifying edge cases, but it doesn't matter. It was optional.
The CQ bit was checked by nodir@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Luci-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3506f69ef8125010)
The CQ bit was checked by nodir@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org Link to the patchset: https://codereview.chromium.org/2752293002/#ps40001 (title: "lint")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Luci-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/351a66c27dbaef10)
On 2017/03/24 18:32:28, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > Luci-py Presubmit on luci.infra.try (JOB_FAILED, > https://luci-milo.appspot.com/swarming/task/351a66c27dbaef10) Looks like there's a bug in threading_utils_test ?
The CQ bit was checked by nodir@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490741565518120,
"parent_rev": "f5b146b60a42e1d8b729d48b795e4c7ea6ccc04d", "commit_rev":
"c497fefe848a225036b03dc7b44454c0c16a55d3"}
Message was sent while issue was closed.
Description was changed from ========== named_caches: make more resilient to corrupted state A state file may be corrupted. Make CacheManager.open() purge cache dir if so. R=maruel@chromium.org BUG=702159 ========== to ========== named_caches: make more resilient to corrupted state A state file may be corrupted. Make CacheManager.open() purge cache dir if so. R=maruel@chromium.org BUG=702159 Review-Url: https://codereview.chromium.org/2752293002 Committed: https://github.com/luci/luci-py/commit/c497fefe848a225036b03dc7b44454c0c16a55d3 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://github.com/luci/luci-py/commit/c497fefe848a225036b03dc7b44454c0c16a55d3 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
