[csa] Add CSA::CallBuiltin and Builtins::CallableFor

[csa] Add CSA::CallBuiltin and Builtins::CallableFor

This is another step towards making calls to builtins more convenient.

Builtins::CallableFor is an automatically generated Callable accessor for TFS
builtins (whereas previously we had to manually add an accessor to
code-factory.{h,cc}).

CSA::CallBuiltin is a convenience wrapper around CallStub for TFS builtins.

We can begin removing accessors for TFS builtins from CodeFactory in an
upcoming commit.

BUG=v8:5737
Review-Url: https://codereview.chromium.org/2752213002
Cr-Commit-Position: refs/heads/master@{#43865}
Committed: https://chromium.googlesource.com/v8/v8/+/a4c73fa704f5015fc259e3e266f72340e5f0ae1a

[jgruber, 2017-03-16 10:01:03]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 10:01:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 10:05:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 10:05:51]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[jgruber, 2017-03-16 10:20:52]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 10:21:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-03-16 10:44:04]

jgruber@chromium.org changed reviewers:
+ ishell@chromium.org

[jgruber, 2017-03-16 10:44:05]

PTAL

cc'd folks: FYI

[commit-bot: I haz the power, 2017-03-16 10:48:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 10:48:35]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-03-16 11:45:37]

yangguo@chromium.org changed reviewers:
+ yangguo@chromium.org

[Yang, 2017-03-16 11:45:38]

awesome cleanup

https://codereview.chromium.org/2752213002/diff/20001/src/code-factory.h
File src/code-factory.h (right):

https://codereview.chromium.org/2752213002/diff/20001/src/code-factory.h#newc...
src/code-factory.h:173: TailCallMode tail_call_mode,
Can we extend this for builtins implemented in MacroAssembler?

[Igor Sheludko, 2017-03-16 12:08:12]

Nice! lgtm

https://codereview.chromium.org/2752213002/diff/20001/src/builtins/builtins.h
File src/builtins/builtins.h (right):

https://codereview.chromium.org/2752213002/diff/20001/src/builtins/builtins.h...
src/builtins/builtins.h:967: static Callable CallableFor(Isolate* isolate, Name
name);
Forward declarations of a base type are suitable for pointer and reference
types. I think you should include the "callable.h" into this header.

[Igor Sheludko, 2017-03-16 12:08:14]

Nice! lgtm

[jgruber, 2017-03-16 12:35:28]

https://codereview.chromium.org/2752213002/diff/20001/src/builtins/builtins.h
File src/builtins/builtins.h (right):

https://codereview.chromium.org/2752213002/diff/20001/src/builtins/builtins.h...
src/builtins/builtins.h:967: static Callable CallableFor(Isolate* isolate, Name
name);
On 2017/03/16 12:08:12, Igor Sheludko wrote:
> Forward declarations of a base type are suitable for pointer and reference
> types. I think you should include the "callable.h" into this header.

I was surprised by this as well, but apparently incomplete types can be used as
arguments and return values in function declarations. We do the same thing with
Handle in this file. Very useful..

See
http://stackoverflow.com/questions/553682/when-can-i-use-a-forward-declaration

https://codereview.chromium.org/2752213002/diff/20001/src/code-factory.h
File src/code-factory.h (right):

https://codereview.chromium.org/2752213002/diff/20001/src/code-factory.h#newc...
src/code-factory.h:173: TailCallMode tail_call_mode,
On 2017/03/16 11:45:38, Yang wrote:
> Can we extend this for builtins implemented in MacroAssembler?

Not sure it's beneficial since many (if not most) ASM builtins are not called as
stubs (see e.g. CompileBaseline, OnStackReplacement, AllocateInNewSpace, ...).
CodeFactory seems like the right place to handle the exceptions.

[jgruber, 2017-03-16 12:36:23]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2017-03-16 12:36:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 12:39:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 12:39:22]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/36840)

[jgruber, 2017-03-16 12:52:59]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-03-16 12:52:59]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2752213002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-16 12:53:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 13:01:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 13:02:01]

Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[jgruber, 2017-03-16 13:06:42]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-03-16 13:06:42]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2752213002/#ps60001
(title: "Remove unused variable again")

[commit-bot: I haz the power, 2017-03-16 13:06:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[caitp, 2017-03-16 13:30:05]

caitp@igalia.com changed reviewers:
+ caitp@igalia.com

[caitp, 2017-03-16 13:30:06]

https://codereview.chromium.org/2752213002/diff/60001/src/builtins/builtins.cc
File src/builtins/builtins.cc (right):

https://codereview.chromium.org/2752213002/diff/60001/src/builtins/builtins.c...
src/builtins/builtins.cc:283: Handle<Code>
code(Code::cast(isolate->builtins()->builtins_[name])); \
Is there any way we could push args in excess of 4 to the stack? It would be
helpful for moving InternelPerformPromiseThen to a stub without doing extra type
checks and loads.

[commit-bot: I haz the power, 2017-03-16 14:22:13]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489669602131980,
"parent_rev": "11f69171c39af1765ed59c03f905399fb76d1058", "commit_rev":
"a4c73fa704f5015fc259e3e266f72340e5f0ae1a"}

[commit-bot: I haz the power, 2017-03-16 14:22:18]

Description was changed from

==========
[csa] Add CSA::CallBuiltin and Builtins::CallableFor

This is another step towards making calls to builtins more convenient.

Builtins::CallableFor is an automatically generated Callable accessor for TFS
builtins (whereas previously we had to manually add an accessor to
code-factory.{h,cc}).

CSA::CallBuiltin is a convenience wrapper around CallStub for TFS builtins.

We can begin removing accessors for TFS builtins from CodeFactory in an
upcoming commit.

BUG=v8:5737
==========

to

==========
[csa] Add CSA::CallBuiltin and Builtins::CallableFor

This is another step towards making calls to builtins more convenient.

Builtins::CallableFor is an automatically generated Callable accessor for TFS
builtins (whereas previously we had to manually add an accessor to
code-factory.{h,cc}).

CSA::CallBuiltin is a convenience wrapper around CallStub for TFS builtins.

We can begin removing accessors for TFS builtins from CodeFactory in an
upcoming commit.

BUG=v8:5737

Review-Url: https://codereview.chromium.org/2752213002
Cr-Commit-Position: refs/heads/master@{#43865}
Committed:
https://chromium.googlesource.com/v8/v8/+/a4c73fa704f5015fc259e3e266f72340e5f...
==========

[commit-bot: I haz the power, 2017-03-16 14:22:19]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/a4c73fa704f5015fc259e3e266f72340e5f...