[csa] Add CSA::CallBuiltin and Builtins::CallableFor

src/builtins/builtins.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_BUILTINS_BUILTINS_H_
 #define V8_BUILTINS_BUILTINS_H_
 
 #include "src/base/flags.h"
 #include "src/globals.h"
 
 namespace v8 {
 namespace internal {
 
+class Callable;
 template <typename T>
 class Handle;
 class Isolate;
 
 #define CODE_AGE_LIST_WITH_ARG(V, A) \
   V(Quadragenarian, A)               \
   V(Quinquagenarian, A)              \
   V(Sexagenarian, A)                 \
   V(Septuagenarian, A)               \
   V(Octogenarian, A)
@@ skipping 855 matching lines @@
   V(PromiseResolve)                                  \
   V(PromiseResolveClosure)                           \
   V(ResolvePromise)
 
 #define BUILTIN_EXCEPTION_CAUGHT_PREDICTION_LIST(V) V(PromiseHandleReject)
 
 #define IGNORE_BUILTIN(...)
 
 #define BUILTIN_LIST_ALL(V) BUILTIN_LIST(V, V, V, V, V, V, V)
 
+#define BUILTIN_LIST_TFS(V)                                       \
+  BUILTIN_LIST(IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, V, \
+               IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN)
+
 #define BUILTIN_LIST_C(V)                                            \
   BUILTIN_LIST(V, V, IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, \
                IGNORE_BUILTIN, IGNORE_BUILTIN)
 
 #define BUILTIN_LIST_A(V)                                                      \
   BUILTIN_LIST(IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, \
                V, V, V)
 
 #define BUILTIN_LIST_DBG(V)                                                    \
   BUILTIN_LIST(IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, \
@@ skipping 53 matching lines @@
   Code* builtin(Name name) {
     // Code::cast cannot be used here since we access builtins
     // during the marking phase of mark sweep. See IC::Clear.
     return reinterpret_cast<Code*>(builtins_[name]);
   }
 
   Address builtin_address(Name name) {
     return reinterpret_cast<Address>(&builtins_[name]);
   }
 
+  static Callable CallableFor(Isolate* isolate, Name name);

[Igor Sheludko, 2017/03/16 12:08:12]

Forward declarations of a base type are suitable for pointer and reference
types. I think you should include the "callable.h" into this header.

[jgruber, 2017/03/16 12:35:27]

I was surprised by this as well, but apparently incomplete types can be used as
arguments and return values in function declarations. We do the same thing with
Handle in this file. Very useful..

See
http://stackoverflow.com/questions/553682/when-can-i-use-a-forward-declaration

+
   static const char* name(int index);
 
   // Returns the C++ entry point for builtins implemented in C++, and the null
   // Address otherwise.
   static Address CppEntryOf(int index);
 
   static bool IsCpp(int index);
   static bool IsApi(int index);
   static bool HasCppImplementation(int index);
 
@@ skipping 53 matching lines @@
 
   friend class Isolate;
 
   DISALLOW_COPY_AND_ASSIGN(Builtins);
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_BUILTINS_BUILTINS_H_