Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 2752173003: Introduce PasswordFormManager::ResetStoredMatches (Closed)

Created:
3 years, 9 months ago by vabr (Chromium)
Modified:
3 years, 9 months ago
Reviewers:
jdoerrie
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce PasswordFormManager::ResetStoredMatches This allows to reset references inside PasswordFormManager to data owned by the associated FormFetcher instances. See https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtPAo/edit#heading=h.jz2q52kebs7k for more details. BUG=621355 Review-Url: https://codereview.chromium.org/2752173003 Cr-Commit-Position: refs/heads/master@{#457731} Committed: https://chromium.googlesource.com/chromium/src/+/b8cefb460f938a1981d70dd7124cfe578c0d3ef2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -0 lines) Patch
M components/password_manager/core/browser/password_form_manager.h View 1 chunk +5 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager_unittest.cc View 1 chunk +61 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
vabr (Chromium)
Hi Jan, Could you please review another CL for me? Thanks, Vaclav
3 years, 9 months ago (2017-03-16 21:15:51 UTC) #6
jdoerrie
LGTM :)
3 years, 9 months ago (2017-03-17 10:23:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752173003/1
3 years, 9 months ago (2017-03-17 10:25:46 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 10:31:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b8cefb460f938a1981d70dd7124c...

Powered by Google App Engine
This is Rietveld 408576698