Introduce FormFetcher::Clone

Introduce FormFetcher::Clone

This allows to clone FormFetcher instances without repeated calls to the
PasswordStore. See
https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtPAo/edit#heading=h.jz2q52kebs7k
for more details.

BUG=621355
Review-Url: https://codereview.chromium.org/2754043002
Cr-Commit-Position: refs/heads/master@{#457554}
Committed: https://chromium.googlesource.com/chromium/src/+/316bf80fdc4c14a6738b9ead44718a30f8cf4f4d

[vabr (Chromium), 2017-03-16 11:13:43]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 11:13:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 11:26:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 11:26:01]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[vabr (Chromium), 2017-03-16 11:45:00]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 11:45:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-03-16 12:02:53]

vabr@chromium.org changed reviewers:
+ vasilii@chromium.org

[vabr (Chromium), 2017-03-16 12:02:55]

Hi Vasilii,

Could you PTAL? This is one of more smaller steps, as explained in the linked
design. Therefore the Clone() method is not used yet, but will be in some
subsequent CL.

Cheers,
Vaclav

[commit-bot: I haz the power, 2017-03-16 12:31:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 12:31:06]

Dry run: This issue passed the CQ dry run.

[vasilii, 2017-03-16 14:16:43]

https://codereview.chromium.org/2754043002/diff/20001/components/password_man...
File components/password_manager/core/browser/form_fetcher_impl_unittest.cc
(right):

https://codereview.chromium.org/2754043002/diff/20001/components/password_man...
components/password_manager/core/browser/form_fetcher_impl_unittest.cc:528:
EXPECT_EQ(FormFetcher::State::WAITING, clone->GetState());
I think having an object in the waiting state is strange because PasswordStore
is never gonna call it.

[vabr (Chromium), 2017-03-16 14:48:29]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 14:48:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-03-16 14:49:08]

Thanks, Vasilii.

I addressed your comment, PTAL again.

Cheers,
Vaclav

https://codereview.chromium.org/2754043002/diff/20001/components/password_man...
File components/password_manager/core/browser/form_fetcher_impl_unittest.cc
(right):

https://codereview.chromium.org/2754043002/diff/20001/components/password_man...
components/password_manager/core/browser/form_fetcher_impl_unittest.cc:528:
EXPECT_EQ(FormFetcher::State::WAITING, clone->GetState());
On 2017/03/16 14:16:43, vasilii wrote:
> I think having an object in the waiting state is strange because PasswordStore
> is never gonna call it.

Done.

[commit-bot: I haz the power, 2017-03-16 15:11:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 15:12:00]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[vasilii, 2017-03-16 15:41:08]

lgtm

[vabr (Chromium), 2017-03-16 19:38:38]

Thanks!

There was a minor issue with the site-statistics test (it used to call Clone()
during WAITING), so I fixed that. I also rebased over my other recent changes in
this area. Sending to the CQ now.

Cheers,
Vaclav

[vabr (Chromium), 2017-03-16 19:38:50]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2017-03-16 19:38:51]

The patchset sent to the CQ was uploaded after l-g-t-m from vasilii@chromium.org
Link to the patchset: https://codereview.chromium.org/2754043002/#ps80001
(title: "Fix stats test")

[commit-bot: I haz the power, 2017-03-16 19:39:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-03-16 20:49:05]

The CQ bit was unchecked by vabr@chromium.org

[vabr (Chromium), 2017-03-16 21:02:46]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2017-03-16 21:03:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 21:12:59]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489698166285940,
"parent_rev": "872d9488f37b30090cdc4ce0fb70ac4c68aaf37c", "commit_rev":
"316bf80fdc4c14a6738b9ead44718a30f8cf4f4d"}

[commit-bot: I haz the power, 2017-03-16 21:13:46]

Description was changed from

==========
Introduce FormFetcher::Clone

This allows to clone FormFetcher instances without repeated calls to the
PasswordStore. See
https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtP...
for more details.

BUG=621355
==========

to

==========
Introduce FormFetcher::Clone

This allows to clone FormFetcher instances without repeated calls to the
PasswordStore. See
https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtP...
for more details.

BUG=621355

Review-Url: https://codereview.chromium.org/2754043002
Cr-Commit-Position: refs/heads/master@{#457554}
Committed:
https://chromium.googlesource.com/chromium/src/+/316bf80fdc4c14a6738b9ead4471...
==========

[commit-bot: I haz the power, 2017-03-16 21:13:47]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/316bf80fdc4c14a6738b9ead4471...