Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h

Issue 2752123002: [LayoutNG] Move NGFloatingObject off Oilpan (Closed)
Patch Set: more comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h b/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h
index f8031d4702fb24fcd9a8dbad928fc49663b7b136..c6c1542cbc25c315ba3eff0646a9a9d75d44346b 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h
@@ -8,8 +8,8 @@
#include "core/CoreExport.h"
#include "core/layout/ng/geometry/ng_logical_offset.h"
#include "core/layout/ng/geometry/ng_margin_strut.h"
+#include "core/layout/ng/ng_floating_object.h"
#include "core/layout/ng/ng_physical_fragment.h"
-#include "platform/heap/Handle.h"
#include "wtf/Optional.h"
namespace blink {
@@ -23,7 +23,7 @@ class CORE_EXPORT NGPhysicalBoxFragment final : public NGPhysicalFragment {
NGPhysicalSize size,
NGPhysicalSize overflow,
Vector<RefPtr<NGPhysicalFragment>>& children,
- Vector<Persistent<NGFloatingObject>>& positioned_floats,
+ Vector<RefPtr<NGFloatingObject>>& positioned_floats,
const WTF::Optional<NGLogicalOffset>& bfc_offset,
const NGMarginStrut& end_margin_strut,
RefPtr<NGBreakToken> break_token = nullptr);
@@ -35,7 +35,7 @@ class CORE_EXPORT NGPhysicalBoxFragment final : public NGPhysicalFragment {
// List of positioned floats that need to be copied to the old layout tree.
// TODO(layout-ng): remove this once we change painting code to handle floats
// differently.
- const Vector<Persistent<NGFloatingObject>>& PositionedFloats() const {
+ const Vector<RefPtr<NGFloatingObject>>& PositionedFloats() const {
return positioned_floats_;
}
@@ -47,7 +47,7 @@ class CORE_EXPORT NGPhysicalBoxFragment final : public NGPhysicalFragment {
private:
Vector<RefPtr<NGPhysicalFragment>> children_;
- Vector<Persistent<NGFloatingObject>> positioned_floats_;
+ Vector<RefPtr<NGFloatingObject>> positioned_floats_;
const WTF::Optional<NGLogicalOffset> bfc_offset_;
const NGMarginStrut end_margin_strut_;
};

Powered by Google App Engine
This is Rietveld 408576698