Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h

Issue 2752123002: [LayoutNG] Move NGFloatingObject off Oilpan (Closed)
Patch Set: more comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NGPhysicalBoxFragment_h 5 #ifndef NGPhysicalBoxFragment_h
6 #define NGPhysicalBoxFragment_h 6 #define NGPhysicalBoxFragment_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "core/layout/ng/geometry/ng_logical_offset.h" 9 #include "core/layout/ng/geometry/ng_logical_offset.h"
10 #include "core/layout/ng/geometry/ng_margin_strut.h" 10 #include "core/layout/ng/geometry/ng_margin_strut.h"
11 #include "core/layout/ng/ng_floating_object.h"
11 #include "core/layout/ng/ng_physical_fragment.h" 12 #include "core/layout/ng/ng_physical_fragment.h"
12 #include "platform/heap/Handle.h"
13 #include "wtf/Optional.h" 13 #include "wtf/Optional.h"
14 14
15 namespace blink { 15 namespace blink {
16 16
17 struct NGFloatingObject; 17 struct NGFloatingObject;
18 18
19 class CORE_EXPORT NGPhysicalBoxFragment final : public NGPhysicalFragment { 19 class CORE_EXPORT NGPhysicalBoxFragment final : public NGPhysicalFragment {
20 public: 20 public:
21 // This modifies the passed-in children vector. 21 // This modifies the passed-in children vector.
22 NGPhysicalBoxFragment(LayoutObject* layout_object, 22 NGPhysicalBoxFragment(LayoutObject* layout_object,
23 NGPhysicalSize size, 23 NGPhysicalSize size,
24 NGPhysicalSize overflow, 24 NGPhysicalSize overflow,
25 Vector<RefPtr<NGPhysicalFragment>>& children, 25 Vector<RefPtr<NGPhysicalFragment>>& children,
26 Vector<Persistent<NGFloatingObject>>& positioned_floats, 26 Vector<RefPtr<NGFloatingObject>>& positioned_floats,
27 const WTF::Optional<NGLogicalOffset>& bfc_offset, 27 const WTF::Optional<NGLogicalOffset>& bfc_offset,
28 const NGMarginStrut& end_margin_strut, 28 const NGMarginStrut& end_margin_strut,
29 RefPtr<NGBreakToken> break_token = nullptr); 29 RefPtr<NGBreakToken> break_token = nullptr);
30 30
31 const Vector<RefPtr<NGPhysicalFragment>>& Children() const { 31 const Vector<RefPtr<NGPhysicalFragment>>& Children() const {
32 return children_; 32 return children_;
33 } 33 }
34 34
35 // List of positioned floats that need to be copied to the old layout tree. 35 // List of positioned floats that need to be copied to the old layout tree.
36 // TODO(layout-ng): remove this once we change painting code to handle floats 36 // TODO(layout-ng): remove this once we change painting code to handle floats
37 // differently. 37 // differently.
38 const Vector<Persistent<NGFloatingObject>>& PositionedFloats() const { 38 const Vector<RefPtr<NGFloatingObject>>& PositionedFloats() const {
39 return positioned_floats_; 39 return positioned_floats_;
40 } 40 }
41 41
42 const WTF::Optional<NGLogicalOffset>& BfcOffset() const { 42 const WTF::Optional<NGLogicalOffset>& BfcOffset() const {
43 return bfc_offset_; 43 return bfc_offset_;
44 } 44 }
45 45
46 const NGMarginStrut& EndMarginStrut() const { return end_margin_strut_; } 46 const NGMarginStrut& EndMarginStrut() const { return end_margin_strut_; }
47 47
48 private: 48 private:
49 Vector<RefPtr<NGPhysicalFragment>> children_; 49 Vector<RefPtr<NGPhysicalFragment>> children_;
50 Vector<Persistent<NGFloatingObject>> positioned_floats_; 50 Vector<RefPtr<NGFloatingObject>> positioned_floats_;
51 const WTF::Optional<NGLogicalOffset> bfc_offset_; 51 const WTF::Optional<NGLogicalOffset> bfc_offset_;
52 const NGMarginStrut end_margin_strut_; 52 const NGMarginStrut end_margin_strut_;
53 }; 53 };
54 54
55 DEFINE_TYPE_CASTS(NGPhysicalBoxFragment, 55 DEFINE_TYPE_CASTS(NGPhysicalBoxFragment,
56 NGPhysicalFragment, 56 NGPhysicalFragment,
57 fragment, 57 fragment,
58 fragment->Type() == NGPhysicalFragment::kFragmentBox, 58 fragment->Type() == NGPhysicalFragment::kFragmentBox,
59 fragment.Type() == NGPhysicalFragment::kFragmentBox); 59 fragment.Type() == NGPhysicalFragment::kFragmentBox);
60 60
61 } // namespace blink 61 } // namespace blink
62 62
63 #endif // NGPhysicalBoxFragment_h 63 #endif // NGPhysicalBoxFragment_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698