Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_layout_result.cc

Issue 2752123002: [LayoutNG] Move NGFloatingObject off Oilpan (Closed)
Patch Set: more comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_layout_result.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_layout_result.cc b/third_party/WebKit/Source/core/layout/ng/ng_layout_result.cc
index 5a45423073d2cea43dcc7f91bc97168ccd8c06b6..c70b9700b32fef4000d0b89f7a6e71c7aac7d901 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_layout_result.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_layout_result.cc
@@ -4,8 +4,6 @@
#include "core/layout/ng/ng_layout_result.h"
-#include "core/layout/ng/ng_floating_object.h"
-
namespace blink {
NGLayoutResult::NGLayoutResult(
@@ -13,10 +11,12 @@ NGLayoutResult::NGLayoutResult(
PersistentHeapLinkedHashSet<WeakMember<NGBlockNode>>&
out_of_flow_descendants,
Vector<NGStaticPosition> out_of_flow_positions,
- Vector<Persistent<NGFloatingObject>>& unpositioned_floats)
+ Vector<RefPtr<NGFloatingObject>>& unpositioned_floats)
: physical_fragment_(physical_fragment),
+ layout_object_(nullptr),
out_of_flow_descendants_(out_of_flow_descendants),
- out_of_flow_positions_(out_of_flow_positions),
- unpositioned_floats_(unpositioned_floats) {}
+ out_of_flow_positions_(out_of_flow_positions) {
+ unpositioned_floats_.swap(unpositioned_floats);
+}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698