Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_layout_result.h

Issue 2752123002: [LayoutNG] Move NGFloatingObject off Oilpan (Closed)
Patch Set: more comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_layout_result.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_layout_result.h b/third_party/WebKit/Source/core/layout/ng/ng_layout_result.h
index 3ec776990cf99fe23231b975227433589e8698ad..64689633dfde025341e81d111a125cb33f70de24 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_layout_result.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_layout_result.h
@@ -7,6 +7,7 @@
#include "core/CoreExport.h"
#include "core/layout/ng/geometry/ng_static_position.h"
+#include "core/layout/ng/ng_floating_object.h"
#include "core/layout/ng/ng_physical_fragment.h"
#include "platform/LayoutUnit.h"
#include "platform/heap/Handle.h"
@@ -15,7 +16,6 @@
namespace blink {
class LayoutObject;
-class NGPhysicalFragment;
class NGBlockNode;
struct NGFloatingObject;
@@ -48,7 +48,7 @@ class CORE_EXPORT NGLayoutResult : public RefCounted<NGLayoutResult> {
// The float cannot be positioned right away inside of the 1st div because
// the vertical position is not known at that moment. It will be known only
// after the 2nd div collapses its margin with its parent.
- const Vector<Persistent<NGFloatingObject>>& UnpositionedFloats() const {
+ const Vector<RefPtr<NGFloatingObject>>& UnpositionedFloats() const {
return unpositioned_floats_;
}
@@ -59,13 +59,13 @@ class CORE_EXPORT NGLayoutResult : public RefCounted<NGLayoutResult> {
PersistentHeapLinkedHashSet<WeakMember<NGBlockNode>>&
out_of_flow_descendants,
Vector<NGStaticPosition> out_of_flow_positions,
- Vector<Persistent<NGFloatingObject>>& unpositioned_floats);
+ Vector<RefPtr<NGFloatingObject>>& unpositioned_floats);
RefPtr<NGPhysicalFragment> physical_fragment_;
LayoutObject* layout_object_;
PersistentHeapLinkedHashSet<WeakMember<NGBlockNode>> out_of_flow_descendants_;
Vector<NGStaticPosition> out_of_flow_positions_;
- Vector<Persistent<NGFloatingObject>> unpositioned_floats_;
+ Vector<RefPtr<NGFloatingObject>> unpositioned_floats_;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698