Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_node.cc

Issue 2752123002: [LayoutNG] Move NGFloatingObject off Oilpan (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
index 773af5f0e1161bb0defba4428527b3e2bb15857b..a957663bf1c9c747aa12efb8b51712b8ff540de9 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
@@ -50,8 +50,9 @@ void FragmentPositionUpdated(const NGPhysicalFragment& fragment) {
// Similar to FragmentPositionUpdated but for floats.
// - Updates layout object's geometric information.
// - Creates legacy FloatingObject and attached it to the provided parent.
-void FloatingObjectPositionedUpdated(NGFloatingObject* ng_floating_object,
- LayoutBox* parent) {
+void FloatingObjectPositionedUpdated(
+ RefPtr<NGFloatingObject> ng_floating_object,
ikilpatrick 2017/03/15 22:45:40 same as comment in block_algorithm, just raw ptr w
Gleb Lanbin 2017/03/15 23:24:25 Done.
+ LayoutBox* parent) {
NGPhysicalBoxFragment* box_fragment =
toNGPhysicalBoxFragment(ng_floating_object->fragment.get());
FragmentPositionUpdated(*box_fragment);

Powered by Google App Engine
This is Rietveld 408576698