Chromium Code Reviews| Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc |
| diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc |
| index b211763d523a66ea6a7271495d23d13118d23bbf..ff2a2df2e5ede9a6aec15b5d6e5d51e3034512c1 100644 |
| --- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc |
| +++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc |
| @@ -162,7 +162,7 @@ NGLogicalOffset CalculateLogicalOffsetForOpportunity( |
| const NGLayoutOpportunity& opportunity, |
| const LayoutUnit float_offset, |
| const NGLogicalOffset& from_offset, |
| - NGFloatingObject* floating_object) { |
| + RefPtr<NGFloatingObject> floating_object) { |
| auto margins = floating_object->margins; |
| // Adjust to child's margin. |
| LayoutUnit inline_offset = margins.inline_start; |
| @@ -185,7 +185,7 @@ NGLogicalOffset CalculateLogicalOffsetForOpportunity( |
| // floating object that is requested to be positioned from {@code origin_point}. |
| NGLogicalOffset PositionFloat(const NGLogicalOffset& origin_point, |
| const NGLogicalOffset& from_offset, |
| - NGFloatingObject* floating_object, |
| + RefPtr<NGFloatingObject> floating_object, |
| NGConstraintSpace* new_parent_space) { |
| const auto* float_space = floating_object->space.get(); |
| DCHECK(floating_object->fragment) << "Fragment cannot be null here"; |
| @@ -222,7 +222,7 @@ NGLogicalOffset PositionFloat(const NGLogicalOffset& origin_point, |
| // and {@code floating_object}'s space and margins. |
| void UpdateFloatingObjectLeftOffset( |
| const NGConstraintSpace& new_parent_space, |
| - const Persistent<NGFloatingObject>& floating_object, |
| + const RefPtr<NGFloatingObject>& floating_object, |
|
ikilpatrick
2017/03/15 22:45:40
so for all these in the anon namespace its probabl
Gleb Lanbin
2017/03/15 23:24:25
Done.
|
| const NGLogicalOffset& float_logical_offset) { |
| // TODO(glebl): We should use physical offset here. |
| floating_object->left_offset = |