Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2751993003: Remove the DeferredInitializationRunner for MemoryMonitor (Closed)

Created:
3 years, 9 months ago by gambard
Modified:
3 years, 9 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the DeferredInitializationRunner for MemoryMonitor The scheduleFreeMemoryMonitoring method post a task to the IO thread to log the free memory. There is no need to defer it further. BUG=649338 Review-Url: https://codereview.chromium.org/2751993003 Cr-Commit-Position: refs/heads/master@{#457732} Committed: https://chromium.googlesource.com/chromium/src/+/5767b2661b42ac05a856e5b8cdbe790daabf1248

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename method #

Patch Set 3 : Fix compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -16 lines) Patch
M ios/chrome/app/main_controller.mm View 1 2 4 chunks +5 lines, -16 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
gambard
PTAL.
3 years, 9 months ago (2017-03-16 09:47:20 UTC) #2
marq (ping after 24h)
https://codereview.chromium.org/2751993003/diff/1/ios/chrome/app/main_controller.mm File ios/chrome/app/main_controller.mm (right): https://codereview.chromium.org/2751993003/diff/1/ios/chrome/app/main_controller.mm#newcode1169 ios/chrome/app/main_controller.mm:1169: - (void)scheduleFreeMemoryMonitoring { Maybe this shouldn't be a schedule.. ...
3 years, 9 months ago (2017-03-16 13:40:58 UTC) #3
gambard
Thanks, PTAL. https://codereview.chromium.org/2751993003/diff/1/ios/chrome/app/main_controller.mm File ios/chrome/app/main_controller.mm (right): https://codereview.chromium.org/2751993003/diff/1/ios/chrome/app/main_controller.mm#newcode1169 ios/chrome/app/main_controller.mm:1169: - (void)scheduleFreeMemoryMonitoring { On 2017/03/16 13:40:58, marq ...
3 years, 9 months ago (2017-03-17 08:57:47 UTC) #4
marq (ping after 24h)
lgtm
3 years, 9 months ago (2017-03-17 09:45:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751993003/20001
3 years, 9 months ago (2017-03-17 09:46:56 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/172398) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-17 09:54:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751993003/40001
3 years, 9 months ago (2017-03-17 10:16:59 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 10:54:43 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5767b2661b42ac05a856e5b8cdbe...

Powered by Google App Engine
This is Rietveld 408576698