Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: ios/chrome/app/main_controller.mm

Issue 2751993003: Remove the DeferredInitializationRunner for MemoryMonitor (Closed)
Patch Set: Fix compilation Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/app/main_controller.mm
diff --git a/ios/chrome/app/main_controller.mm b/ios/chrome/app/main_controller.mm
index 86e67ba58b16b6633835ad0a6240be1d6d989e03..b32b6e850a2744571ace8481134e665e7d0df2ff 100644
--- a/ios/chrome/app/main_controller.mm
+++ b/ios/chrome/app/main_controller.mm
@@ -167,9 +167,6 @@ NSString* const kStartupAttemptReset = @"StartupAttempReset";
// Constants for deferring memory debugging tools startup.
NSString* const kMemoryDebuggingToolsStartup = @"MemoryDebuggingToolsStartup";
-// Constants for deferring memory monitoring startup.
-NSString* const kMemoryMonitoring = @"MemoryMonitoring";
-
// Constants for deferred check if it is necessary to send pings to
// Chrome distribution related services.
NSString* const kSendInstallPingIfNecessary = @"SendInstallPingIfNecessary";
@@ -479,7 +476,7 @@ enum class StackViewDismissalMode { NONE, NORMAL, INCOGNITO };
// Asynchronously schedule the init of the memoryDebuggerManager.
- (void)scheduleMemoryDebuggingTools;
// Asynchronously kick off regular free memory checks.
-- (void)scheduleFreeMemoryMonitoring;
+- (void)startFreeMemoryMonitoring;
// Asynchronously schedules the notification of the AuthenticationService.
- (void)scheduleAuthenticationServiceNotification;
// Asynchronously schedules the reset of the failed startup attempt counter.
@@ -1166,17 +1163,9 @@ enum class StackViewDismissalMode { NONE, NORMAL, INCOGNITO };
}
}
-- (void)scheduleFreeMemoryMonitoring {
- // TODO(crbug.com/649338): See if this method cannot call PostBlockingPoolTask
- // directly instead of enqueueing a block.
- [[DeferredInitializationRunner sharedInstance]
- enqueueBlockNamed:kMemoryMonitoring
- block:^{
- web::WebThread::PostBlockingPoolTask(
- FROM_HERE,
- base::Bind(
- &ios_internal::AsynchronousFreeMemoryMonitor));
- }];
+- (void)startFreeMemoryMonitoring {
+ web::WebThread::PostBlockingPoolTask(
+ FROM_HERE, base::Bind(&ios_internal::AsynchronousFreeMemoryMonitor));
}
- (void)scheduleLowPriorityStartupTasks {
@@ -1193,7 +1182,7 @@ enum class StackViewDismissalMode { NONE, NORMAL, INCOGNITO };
[self scheduleSpotlightResync];
[self scheduleDeleteDownloadsDirectory];
[self scheduleStartupAttemptReset];
- [self scheduleFreeMemoryMonitoring];
+ [self startFreeMemoryMonitoring];
[self scheduleAppDistributionPings];
[self scheduleCheckNativeApps];
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698