Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2751913007: Revert of [ignition] Decrease code size multiiplier to 24. (Closed)

Created:
3 years, 9 months ago by Benedikt Meurer
Modified:
3 years, 9 months ago
Reviewers:
Jarin, rmcilroy, danno
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [ignition] Decrease code size multiiplier to 24. (patchset #1 id:1 of https://codereview.chromium.org/2758503002/ ) Reason for revert: Doesn't seem to help with peak performance, and seems to hurt startup performance a bit, so reverting for now Original issue's description: > [ignition] Decrease code size multiplier to 24. > > BUG= > > Review-Url: https://codereview.chromium.org/2758503002 > Cr-Commit-Position: refs/heads/master@{#43861} > Committed: https://chromium.googlesource.com/v8/v8/+/b880309bc7f2c4be67f12bac04249f09b0fdd66d TBR=rmcilroy@chromium.org,jarin@chromium.org,danno@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2751913007 Cr-Commit-Position: refs/heads/master@{#43891} Committed: https://chromium.googlesource.com/v8/v8/+/6934d9222035cb5ba6ce243e66b8def1945dca03

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/interpreter/interpreter.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Benedikt Meurer
Created Revert of [ignition] Decrease code size multiiplier to 24.
3 years, 9 months ago (2017-03-17 11:19:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751913007/1
3 years, 9 months ago (2017-03-17 11:20:05 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 11:20:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/6934d9222035cb5ba6ce243e66b8def1945...

Powered by Google App Engine
This is Rietveld 408576698