Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2758503002:
[ignition] Decrease code size multiplier to 24. (Closed)
|
Created:
3 years, 9 months ago by Benedikt Meurer Modified:
3 years, 9 months ago CC:
v8-reviews_googlegroups.com Target Ref:
refs/heads/master Project:
v8 Visibility:
Public. |
Description[ignition] Decrease code size multiplier to 24.
BUG=
Review-Url: https://codereview.chromium.org/2758503002
Cr-Original-Commit-Position: refs/heads/master@{#43861}
Committed: https://chromium.googlesource.com/v8/v8/+/b880309bc7f2c4be67f12bac04249f09b0fdd66d
Review-Url: https://codereview.chromium.org/2758503002
Cr-Commit-Position: refs/heads/master@{#44002}
Committed: https://chromium.googlesource.com/v8/v8/+/f0e3f8ea6f5b614259c6b5f1b87d64f31711f0bb
Patch Set 1 #Patch Set 2 : REBASE #Messages
Total messages: 29 (19 generated)
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
bmeurer@chromium.org changed reviewers: + danno@chromium.org, jarin@chromium.org, rmcilroy@chromium.org
Using 24 as code size multiplier for Ignition seems to help Speedometer by about 2% on average, and doesn't seem to really negatively impact other things. Shall we try to land this and see the startup impact?
On 2017/03/16 10:19:44, Benedikt Meurer wrote: > Using 24 as code size multiplier for Ignition seems to help Speedometer by about > 2% on average, and doesn't seem to really negatively impact other things. Shall > we try to land this and see the startup impact? Sounds good, let's land and keep an eye on the bots LGTM.
Description was changed from ========== [ignition] Decrease code size multiiplier to 24. BUG= ========== to ========== [ignition] Decrease code size multiplier to 24. BUG= ==========
The CQ bit was checked by bmeurer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1489666694312520, "parent_rev":
"2b3fbd8208e41274223e9bda965202833109ef5e", "commit_rev":
"b880309bc7f2c4be67f12bac04249f09b0fdd66d"}
Message was sent while issue was closed.
Description was changed from ========== [ignition] Decrease code size multiplier to 24. BUG= ========== to ========== [ignition] Decrease code size multiplier to 24. BUG= Review-Url: https://codereview.chromium.org/2758503002 Cr-Commit-Position: refs/heads/master@{#43861} Committed: https://chromium.googlesource.com/v8/v8/+/b880309bc7f2c4be67f12bac04249f09b0f... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/b880309bc7f2c4be67f12bac04249f09b0f...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2751913007/ by bmeurer@chromium.org. The reason for reverting is: Doesn't seem to help with peak performance, and seems to hurt startup performance a bit, so reverting for now.
Message was sent while issue was closed.
Description was changed from ========== [ignition] Decrease code size multiplier to 24. BUG= Review-Url: https://codereview.chromium.org/2758503002 Cr-Commit-Position: refs/heads/master@{#43861} Committed: https://chromium.googlesource.com/v8/v8/+/b880309bc7f2c4be67f12bac04249f09b0f... ========== to ========== [ignition] Decrease code size multiplier to 24. BUG= Review-Url: https://codereview.chromium.org/2758503002 Cr-Commit-Position: refs/heads/master@{#43861} Committed: https://chromium.googlesource.com/v8/v8/+/b880309bc7f2c4be67f12bac04249f09b0f... ==========
Let's try again with jarin@'s tick reset fix.
The CQ bit was checked by bmeurer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for src/interpreter/interpreter.h:
While running git apply --index -p1;
error: patch failed: src/interpreter/interpreter.h:67
error: src/interpreter/interpreter.h: patch does not apply
Patch: src/interpreter/interpreter.h
Index: src/interpreter/interpreter.h
diff --git a/src/interpreter/interpreter.h b/src/interpreter/interpreter.h
index
3a92df40378ea0fe22f511a75e76152265699dff..fa9c65dfdf28f1bf3f8e1ef0ffa58138d989c5b0
100644
--- a/src/interpreter/interpreter.h
+++ b/src/interpreter/interpreter.h
@@ -67,7 +67,7 @@ class Interpreter {
}
// TODO(ignition): Tune code size multiplier.
- static const int kCodeSizeMultiplier = 32;
+ static const int kCodeSizeMultiplier = 24;
private:
// Bytecode handler generator functions.
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by bmeurer@chromium.org
The CQ bit was checked by bmeurer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rmcilroy@chromium.org Link to the patchset: https://codereview.chromium.org/2758503002/#ps20001 (title: "REBASE")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490168525826820,
"parent_rev": "07a43140d4ead19f5a9dc256f0a17b473e4a3872", "commit_rev":
"f0e3f8ea6f5b614259c6b5f1b87d64f31711f0bb"}
Message was sent while issue was closed.
Description was changed from ========== [ignition] Decrease code size multiplier to 24. BUG= Review-Url: https://codereview.chromium.org/2758503002 Cr-Commit-Position: refs/heads/master@{#43861} Committed: https://chromium.googlesource.com/v8/v8/+/b880309bc7f2c4be67f12bac04249f09b0f... ========== to ========== [ignition] Decrease code size multiplier to 24. BUG= Review-Url: https://codereview.chromium.org/2758503002 Cr-Original-Commit-Position: refs/heads/master@{#43861} Committed: https://chromium.googlesource.com/v8/v8/+/b880309bc7f2c4be67f12bac04249f09b0f... Review-Url: https://codereview.chromium.org/2758503002 Cr-Commit-Position: refs/heads/master@{#44002} Committed: https://chromium.googlesource.com/v8/v8/+/f0e3f8ea6f5b614259c6b5f1b87d64f3171... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/f0e3f8ea6f5b614259c6b5f1b87d64f3171... |
