Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2751833009: DevTools: Don't trigger panel switcher shortcut if alt key is held (Closed)

Created:
3 years, 9 months ago by kozy
Modified:
3 years, 9 months ago
Reviewers:
pfeldman
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

DevTools: Don't trigger panel switcher shortcut if alt key is held On Windows with some international keyboard layouts, typing [ might report that both ctrl and alt are pressed. BUG=685993 Review-Url: https://codereview.chromium.org/2680773003 Cr-Commit-Position: refs/heads/master@{#448824} (cherry picked from commit 85d052a58e40fa393e1daa4e3b1848c2b0530607) Review-Url: https://codereview.chromium.org/2751833009 . Cr-Commit-Position: refs/branch-heads/2987@{#829} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/8e36e1c3d473f53199e9bdfb841fcfaf4c317dad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
pfeldman
lgtm
3 years, 9 months ago (2017-03-15 20:05:09 UTC) #2
kozy
3 years, 9 months ago (2017-03-15 20:06:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8e36e1c3d473f53199e9bdfb841fcfaf4c317dad.

Powered by Google App Engine
This is Rietveld 408576698