DevTools: Don't trigger panel switcher shortcut if alt key is held

DevTools: Don't trigger panel switcher shortcut if alt key is held

On Windows with some international keyboard layouts, typing [ might
report that both ctrl and alt are pressed.

BUG=685993
Review-Url: https://codereview.chromium.org/2680773003
Cr-Commit-Position: refs/heads/master@{#448824}
Committed: https://chromium.googlesource.com/chromium/src/+/85d052a58e40fa393e1daa4e3b1848c2b0530607

[einbinder, 2017-02-07 22:40:29]

einbinder@chromium.org changed reviewers:
+ pfeldman@chromium.org

[einbinder, 2017-02-07 22:40:29]

ptal

[einbinder, 2017-02-07 22:40:32]

The CQ bit was checked by einbinder@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 22:42:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2017-02-07 22:50:16]

https://codereview.chromium.org/2680773003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js (right):

https://codereview.chromium.org/2680773003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js:234: if
(!UI.KeyboardShortcut.eventHasCtrlOrMeta(keyboardEvent) || event.altKey ||
event.shiftKey)
lgtm, but we might need to merge :(

[commit-bot: I haz the power, 2017-02-08 00:10:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 00:10:22]

Dry run: This issue passed the CQ dry run.

[einbinder, 2017-02-08 00:28:14]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2017-02-08 00:29:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 00:54:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486513694423140, "parent_rev":
"5fa493d68730231fb936bd309c3d6814686135fb", "commit_rev":
"85d052a58e40fa393e1daa4e3b1848c2b0530607"}

[commit-bot: I haz the power, 2017-02-08 00:55:50]

Description was changed from

==========
DevTools: Don't trigger panel switcher shortcut if alt key is held

On Windows with some international keyboard layouts, typing [ might
report that both ctrl and alt are pressed.

BUG=685993
==========

to

==========
DevTools: Don't trigger panel switcher shortcut if alt key is held

On Windows with some international keyboard layouts, typing [ might
report that both ctrl and alt are pressed.

BUG=685993

Review-Url: https://codereview.chromium.org/2680773003
Cr-Commit-Position: refs/heads/master@{#448824}
Committed:
https://chromium.googlesource.com/chromium/src/+/85d052a58e40fa393e1daa4e3b18...
==========

[commit-bot: I haz the power, 2017-02-08 00:55:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/85d052a58e40fa393e1daa4e3b18...