Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2680773003: DevTools: Don't trigger panel switcher shortcut if alt key is held (Closed)

Created:
3 years, 10 months ago by einbinder
Modified:
3 years, 10 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Don't trigger panel switcher shortcut if alt key is held On Windows with some international keyboard layouts, typing [ might report that both ctrl and alt are pressed. BUG=685993 Review-Url: https://codereview.chromium.org/2680773003 Cr-Commit-Position: refs/heads/master@{#448824} Committed: https://chromium.googlesource.com/chromium/src/+/85d052a58e40fa393e1daa4e3b1848c2b0530607

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 12 (8 generated)
einbinder
ptal
3 years, 10 months ago (2017-02-07 22:40:29 UTC) #2
pfeldman
https://codereview.chromium.org/2680773003/diff/1/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js File third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js (right): https://codereview.chromium.org/2680773003/diff/1/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js#newcode234 third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js:234: if (!UI.KeyboardShortcut.eventHasCtrlOrMeta(keyboardEvent) || event.altKey || event.shiftKey) lgtm, but we ...
3 years, 10 months ago (2017-02-07 22:50:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680773003/1
3 years, 10 months ago (2017-02-08 00:29:17 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 00:55:51 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/85d052a58e40fa393e1daa4e3b18...

Powered by Google App Engine
This is Rietveld 408576698