Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 2751833004: Reland "Add display::GetDisplayNearestView" (Closed)

Created:
3 years, 9 months ago by Jinsuk Kim
Modified:
3 years, 9 months ago
Reviewers:
benwells
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, dcheng, extensions-reviews_chromium.org, ios-reviews_chromium.org, lcwu+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, awdf+watch_chromium.org, halliwell+watch_chromium.org, chromium-apps-reviews_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, feature-vr-reviews_chromium.org, oshima+watch_chromium.org, kalyank, alokp+watch_chromium.org, Matt Giuca, tfarina, shuchen+watch_chromium.org, mac-reviews_chromium.org, James Su, robliao+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Add display::GetDisplayNearestView" Reverted CL: https://crrev.com/2688413007 Fixed a missing signature mismatch to make the build work. (extensions/browser/api/system_display/system_display_apitest.cc) This reverts commit a0c89e94b3310fa12b58db00eaca0e66c2f98c7b. BUG=699891 TBR=sky@chromium.org,boliu@chromium.org,msw@chromium.org,halliwell@chromium.org,bshe@chromium.org,alexclarke@chromium.org,oshima@chromium.org,tapted@chromium.org Review-Url: https://codereview.chromium.org/2751833004 Cr-Commit-Position: refs/heads/master@{#457653} Committed: https://chromium.googlesource.com/chromium/src/+/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -59 lines) Patch
M chrome/browser/android/vr_shell/vr_shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/display/output_protection_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/site_per_process_interactive_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/profiles/user_manager_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/status_bubble_views.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/validation_message_bubble_view.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_common_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/graphics/cast_screen.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/constrained_window/constrained_window_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/system_display/system_display_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_screen.h View 1 chunk +2 lines, -1 line 0 comments Download
M headless/lib/browser/headless_screen.h View 1 chunk +2 lines, -1 line 0 comments Download
M headless/lib/browser/headless_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/android/display_android_manager.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/android/display_android_manager.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M ui/android/dummy_screen_android.cc View 1 chunk +5 lines, -1 line 0 comments Download
M ui/app_list/presenter/app_list_presenter_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/test_screen.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/base/layout.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/display/ios/screen_ios.mm View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/display/mac/screen_mac.mm View 2 chunks +10 lines, -6 lines 0 comments Download
M ui/display/screen.h View 2 chunks +8 lines, -1 line 0 comments Download
M ui/display/screen.cc View 1 chunk +6 lines, -2 lines 0 comments Download
A ui/display/screen_android.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M ui/display/screen_aura.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/display/screen_base.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/screen_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/test/test_screen.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/test/test_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/win/screen_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/display/win/screen_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/toast_contents_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/screen_mus.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/mus/screen_mus.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Jinsuk Kim
One more file was added to https://crrev.com/2688413007/ benwells@ would you take a look at the ...
3 years, 9 months ago (2017-03-15 12:23:14 UTC) #6
benwells
On 2017/03/15 12:23:14, Jinsuk Kim wrote: > One more file was added to https://crrev.com/2688413007/ > ...
3 years, 9 months ago (2017-03-16 06:28:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751833004/1
3 years, 9 months ago (2017-03-16 23:34:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493
3 years, 9 months ago (2017-03-17 01:55:17 UTC) #13
Jinsuk Kim
3 years, 9 months ago (2017-03-17 02:25:55 UTC) #14
Message was sent while issue was closed.
benwells@ ui/apps_list, extensions/
halliwell@ chromecast/
bshe@ chrome/browser/android/vr_shell
msw@ chrome/browser/ui/views, components/constrained_window
boliu@ contents/browser, ui/android
alexclarke@ headless/
sky@ ui/aura, ui/base, ui/snapshot
oshima@ ui/display
tapted@ ui/views

Powered by Google App Engine
This is Rietveld 408576698