Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService.java

Issue 2751813004: Fix the download summary notification icons (Closed)
Patch Set: Fixed test compile error Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService.java b/chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService.java
index 6bc32bc7048bb9c9c5977044f494695c1f6df38f..29737f98ec2f0bf8d0ad689a210380c92d04eaf7 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService.java
@@ -43,11 +43,11 @@ public class MockDownloadNotificationService extends DownloadNotificationService
}
@Override
- boolean hasDownloadNotifications(Integer notificationIdToIgnore) {
+ boolean hasDownloadNotificationsInternal(int notificationIdToIgnore) {
if (!useForegroundService()) return false;
// Cancelling notifications here is synchronous, so we don't really have to worry about
// {@code notificationIdToIgnore}, but address it properly anyway.
- if (mNotificationIds.size() == 1 && notificationIdToIgnore != null) {
+ if (mNotificationIds.size() == 1 && notificationIdToIgnore != -1) {
return !mNotificationIds.contains(notificationIdToIgnore);
}
@@ -55,7 +55,7 @@ public class MockDownloadNotificationService extends DownloadNotificationService
}
@Override
- void updateSummaryIcon(
+ void updateSummaryIconInternal(
int removedNotificationId, Pair<Integer, Notification> addedNotification) {}
@Override
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698