Fixed SystemAccountManagerDelegate.updateCredentials on KitKat

Fixed SystemAccountManagerDelegate.updateCredentials on KitKat

AccountManager.updateCredentials on Android KitKat fails because of
NullPointerException in authenticator. Passing empty Bundle instead of null
fixes the problem.

BUG=699050
Review-Url: https://codereview.chromium.org/2751733002
Cr-Commit-Position: refs/heads/master@{#456723}
Committed: https://chromium.googlesource.com/chromium/src/+/255225462a687af278ab3118122638816dd4a212

[bsazonov, 2017-03-14 15:02:36]

The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 15:02:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bsazonov, 2017-03-14 15:03:40]

bsazonov@chromium.org changed reviewers:
+ msarda@chromium.org

[bsazonov, 2017-03-14 15:03:40]

Mihai, please take a look.

[msarda, 2017-03-14 15:07:14]

LGTM with a nit.

https://codereview.chromium.org/2751733002/diff/1/components/signin/core/brow...
File
components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java
(right):

https://codereview.chromium.org/2751733002/diff/1/components/signin/core/brow...
components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java:196:
Bundle params = new Bundle(); // Android 4.4 throws NullPointerException if null
is passed
Nit: s/params/empty_options

[bsazonov, 2017-03-14 15:21:21]

https://codereview.chromium.org/2751733002/diff/1/components/signin/core/brow...
File
components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java
(right):

https://codereview.chromium.org/2751733002/diff/1/components/signin/core/brow...
components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java:196:
Bundle params = new Bundle(); // Android 4.4 throws NullPointerException if null
is passed
On 2017/03/14 15:07:14, msarda wrote:
> Nit: s/params/empty_options

Done.

[bsazonov, 2017-03-14 15:21:41]

The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 15:22:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 15:59:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 15:59:22]

Dry run: This issue passed the CQ dry run.

[bsazonov, 2017-03-14 16:12:55]

The CQ bit was checked by bsazonov@chromium.org

[bsazonov, 2017-03-14 16:12:55]

The patchset sent to the CQ was uploaded after l-g-t-m from msarda@chromium.org
Link to the patchset: https://codereview.chromium.org/2751733002/#ps20001
(title: "Addressed comment")

[commit-bot: I haz the power, 2017-03-14 16:13:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 16:24:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489507975036850,
"parent_rev": "16ce460b6793b9fff0c1d4cc72deab60b921a159", "commit_rev":
"255225462a687af278ab3118122638816dd4a212"}

[commit-bot: I haz the power, 2017-03-14 16:24:50]

Description was changed from

==========
Fixed SystemAccountManagerDelegate.updateCredentials on KitKat

AccountManager.updateCredentials on Android KitKat fails because of
NullPointerException in authenticator. Passing empty Bundle instead of null
fixes the problem.

BUG=699050
==========

to

==========
Fixed SystemAccountManagerDelegate.updateCredentials on KitKat

AccountManager.updateCredentials on Android KitKat fails because of
NullPointerException in authenticator. Passing empty Bundle instead of null
fixes the problem.

BUG=699050

Review-Url: https://codereview.chromium.org/2751733002
Cr-Commit-Position: refs/heads/master@{#456723}
Committed:
https://chromium.googlesource.com/chromium/src/+/255225462a687af278ab31181226...
==========

[commit-bot: I haz the power, 2017-03-14 16:24:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/255225462a687af278ab31181226...