Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java

Issue 2751733002: Fixed SystemAccountManagerDelegate.updateCredentials on KitKat (Closed)
Patch Set: Addressed comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java
diff --git a/components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java b/components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java
index 1f27097c1f1297f8058ec91fb10aa9433ced9998..6cc91e8c3a598fb0061c99b921481f71e47c17a0 100644
--- a/components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java
+++ b/components/signin/core/browser/android/java/src/org/chromium/components/signin/SystemAccountManagerDelegate.java
@@ -193,7 +193,10 @@ public class SystemAccountManagerDelegate implements AccountManagerDelegate {
}
}
};
- mAccountManager.updateCredentials(account, "android", null, activity, realCallback, null);
+ // Android 4.4 throws NullPointerException if null is passed
+ Bundle emptyOptions = new Bundle();
+ mAccountManager.updateCredentials(
+ account, "android", emptyOptions, activity, realCallback, null);
}
protected boolean hasGetAccountsPermission() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698