Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2751603002: Remove the alternative preferences filename from JsonPrefStore. (Closed)

Created:
3 years, 9 months ago by Sam McNally
Modified:
3 years, 9 months ago
Reviewers:
gab, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the alternative preferences filename from JsonPrefStore. The alternative pref filename kProtectedPreferencesFilenameDeprecated was slated for removal sometime after M40. This removes it and the code supporting it in JsonPrefStore. BUG=654988 Review-Url: https://codereview.chromium.org/2751603002 Cr-Commit-Position: refs/heads/master@{#457310} Committed: https://chromium.googlesource.com/chromium/src/+/f420c16e98fed89f8a2a0675e0c859bfd0b52b3e

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -221 lines) Patch
M chrome/browser/prefs/profile_pref_store_manager.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/prefs/tracked/pref_hash_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_constants.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/prefs/json_pref_store.h View 2 chunks +0 lines, -12 lines 0 comments Download
M components/prefs/json_pref_store.cc View 4 chunks +4 lines, -22 lines 0 comments Download
M components/prefs/json_pref_store_unittest.cc View 2 chunks +0 lines, -180 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 25 (19 generated)
Sam McNally
+gab for //components/prefs and //chrome/browser/prefs +sky for //chrome/common
3 years, 9 months ago (2017-03-14 00:49:14 UTC) #11
sky
chrome/common LGTM
3 years, 9 months ago (2017-03-14 03:31:00 UTC) #14
Sam McNally
-gab, +bauerb
3 years, 9 months ago (2017-03-15 01:35:39 UTC) #18
gab
lgtm (sorry for delay) -bauerb
3 years, 9 months ago (2017-03-15 14:13:14 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751603002/20001
3 years, 9 months ago (2017-03-16 00:26:09 UTC) #22
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 02:12:07 UTC) #25
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f420c16e98fed89f8a2a0675e0c8...

Powered by Google App Engine
This is Rietveld 408576698