Convert PrefHashFilter enums to enum class.

Convert PrefHashFilter enums to enum class.

The enums in PrefHashFilter will soon be mojom-generated.
Mojom-generated enums are always enum class enums. This changes those
enums to be enum class enums in preparation of that change.

BUG=654988
Review-Url: https://codereview.chromium.org/2752533002
Cr-Commit-Position: refs/heads/master@{#457276}
Committed: https://chromium.googlesource.com/chromium/src/+/6810f4a0e51ff154c73f1540772f8b65ce117acd

[Sam McNally, 2017-03-13 23:27:00]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 23:27:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 00:12:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 00:12:30]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2017-03-14 00:15:59]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 00:16:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2017-03-14 00:18:17]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-03-14 00:29:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 00:29:39]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Sam McNally, 2017-03-14 00:45:01]

sammc@chromium.org changed reviewers:
+ gab@chromium.org

[Sam McNally, 2017-03-14 03:02:32]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 03:03:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 03:40:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 03:40:13]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2017-03-15 01:35:06]

sammc@chromium.org changed reviewers:
+ bauerb@chromium.org
- gab@chromium.org

[Sam McNally, 2017-03-15 01:35:06]

-gab, +bauerb

[gab, 2017-03-15 14:16:35]

gab@chromium.org changed reviewers:
+ gab@chromium.org
- bauerb@chromium.org

[gab, 2017-03-15 14:16:36]

lgtm thanks (sorry for delay)

-bauerb

https://codereview.chromium.org/2752533002/diff/20001/chrome/browser/prefs/ch...
File chrome/browser/prefs/chrome_pref_service_factory.cc (right):

https://codereview.chromium.org/2752533002/diff/20001/chrome/browser/prefs/ch...
chrome/browser/prefs/chrome_pref_service_factory.cc:101:
PrefHashFilter::EnforcementLevel::ENFORCE_ON_LOAD,
Let's add 

using PrefHashFilter::EnforcementLevel;
using PrefHashFilter::PrefTrackingStrategy;
using PrefHashFilter::ValueType;

statements above to avoid so much boilerplate in this list.

https://codereview.chromium.org/2752533002/diff/20001/components/user_prefs/t...
File components/user_prefs/tracked/pref_hash_filter_unittest.cc (right):

https://codereview.chromium.org/2752533002/diff/20001/components/user_prefs/t...
components/user_prefs/tracked/pref_hash_filter_unittest.cc:45: {0, kAtomicPref,
PrefHashFilter::EnforcementLevel::ENFORCE_ON_LOAD,
using statements in this file too

[Sam McNally, 2017-03-15 22:41:41]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 22:42:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 00:08:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 00:08:05]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2017-03-16 00:09:36]

https://codereview.chromium.org/2752533002/diff/20001/chrome/browser/prefs/ch...
File chrome/browser/prefs/chrome_pref_service_factory.cc (right):

https://codereview.chromium.org/2752533002/diff/20001/chrome/browser/prefs/ch...
chrome/browser/prefs/chrome_pref_service_factory.cc:101:
PrefHashFilter::EnforcementLevel::ENFORCE_ON_LOAD,
On 2017/03/15 14:16:36, gab wrote:
> Let's add 
> 
> using PrefHashFilter::EnforcementLevel;
> using PrefHashFilter::PrefTrackingStrategy;
> using PrefHashFilter::ValueType;
> 
> statements above to avoid so much boilerplate in this list.

Done.

https://codereview.chromium.org/2752533002/diff/20001/components/user_prefs/t...
File components/user_prefs/tracked/pref_hash_filter_unittest.cc (right):

https://codereview.chromium.org/2752533002/diff/20001/components/user_prefs/t...
components/user_prefs/tracked/pref_hash_filter_unittest.cc:45: {0, kAtomicPref,
PrefHashFilter::EnforcementLevel::ENFORCE_ON_LOAD,
On 2017/03/15 14:16:36, gab wrote:
> using statements in this file too

Done.

[Sam McNally, 2017-03-16 00:09:46]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2017-03-16 00:09:46]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org
Link to the patchset: https://codereview.chromium.org/2752533002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2017-03-16 00:10:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 00:17:20]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489622986313890,
"parent_rev": "09fb15d21c53769e466ea5a80bd3a170082e7bfe", "commit_rev":
"6810f4a0e51ff154c73f1540772f8b65ce117acd"}

[commit-bot: I haz the power, 2017-03-16 00:18:37]

Description was changed from

==========
Convert PrefHashFilter enums to enum class.

The enums in PrefHashFilter will soon be mojom-generated.
Mojom-generated enums are always enum class enums. This changes those
enums to be enum class enums in preparation of that change.

BUG=654988
==========

to

==========
Convert PrefHashFilter enums to enum class.

The enums in PrefHashFilter will soon be mojom-generated.
Mojom-generated enums are always enum class enums. This changes those
enums to be enum class enums in preparation of that change.

BUG=654988

Review-Url: https://codereview.chromium.org/2752533002
Cr-Commit-Position: refs/heads/master@{#457276}
Committed:
https://chromium.googlesource.com/chromium/src/+/6810f4a0e51ff154c73f1540772f...
==========

[commit-bot: I haz the power, 2017-03-16 00:18:39]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6810f4a0e51ff154c73f1540772f...