Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 2751553002: Check for invalid dimensions in glTexStorage* (Closed)

Created:
3 years, 9 months ago by Kai Ninomiya
Modified:
3 years, 9 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check for invalid dimensions in glTexStorage* width, height, or depth of 0 are invalid for glTexStorage, but valid for most other texture entry points, so this case wasn't covered by TextureManager::ValidForTarget. BUG=700270 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2751553002 Cr-Commit-Position: refs/heads/master@{#456615} Committed: https://chromium.googlesource.com/chromium/src/+/87b070a02a9413d0b48fd7ebd0d1c271c2f657c5

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 1 chunk +7 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Kai Ninomiya
kbr, PTAL.
3 years, 9 months ago (2017-03-13 22:58:48 UTC) #7
Ken Russell (switch to Gerrit)
Great. Good unit test. LGTM
3 years, 9 months ago (2017-03-14 03:00:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751553002/40001
3 years, 9 months ago (2017-03-14 03:02:43 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 03:29:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/87b070a02a9413d0b48fd7ebd0d1...

Powered by Google App Engine
This is Rietveld 408576698