Check for invalid dimensions in glTexStorage*

gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include "base/command_line.h"
@@ skipping 4345 matching lines @@
   init.bind_generates_resource = true;
   InitDecoder(init);
   DoBindTexture(GL_TEXTURE_RECTANGLE_ARB, client_texture_id_,
                 kServiceTextureId);
   TexStorage2DEXT cmd;
   cmd.Init(GL_TEXTURE_RECTANGLE_ARB, 2, GL_RGBA8, 4, 4);
   EXPECT_EQ(error::kNoError, ExecuteCmd(cmd));
   EXPECT_EQ(GL_INVALID_VALUE, GetGLError());
 }
 
+TEST_P(GLES2DecoderManualInitTest, TexStorageInvalidSize) {
+  InitState init;
+  init.gl_version = "OpenGL 4.2";
+  init.extensions = "GL_ARB_texture_storage";
+  init.bind_generates_resource = true;
+  InitDecoder(init);
+  DoBindTexture(GL_TEXTURE_2D, client_texture_id_, kServiceTextureId);
+  {
+    TexStorage2DEXT cmd;
+    cmd.Init(GL_TEXTURE_2D, 1, GL_RGBA8, 0, 4);
+    EXPECT_EQ(error::kNoError, ExecuteCmd(cmd));
+    EXPECT_EQ(GL_INVALID_VALUE, GetGLError());
+  }
+  {
+    TexStorage2DEXT cmd;
+    cmd.Init(GL_TEXTURE_2D, 1, GL_RGBA8, 4, 0);
+    EXPECT_EQ(error::kNoError, ExecuteCmd(cmd));
+    EXPECT_EQ(GL_INVALID_VALUE, GetGLError());
+  }
+  {
+    TexStorage2DEXT cmd;
+    cmd.Init(GL_TEXTURE_2D, 1, GL_RGBA8, 0, 0);
+    EXPECT_EQ(error::kNoError, ExecuteCmd(cmd));
+    EXPECT_EQ(GL_INVALID_VALUE, GetGLError());
+  }
+}
+
 class GLES2DecoderTexStorageFormatAndTypeTest
     : public GLES2DecoderManualInitTest {
  public:
   GLES2DecoderTexStorageFormatAndTypeTest() {}
 
   void DoTexStorageFormatAndType(const InitState& init,
                                  GLenum format,
                                  GLenum adjusted_internal_format) {
     InitDecoder(init);
     DoBindTexture(GL_TEXTURE_2D, client_texture_id_, kServiceTextureId);
@@ skipping 467 matching lines @@
 // TODO(gman): CompressedTexSubImage2DImmediate
 
 // TODO(gman): TexImage2D
 
 // TODO(gman): TexImage2DImmediate
 
 // TODO(gman): TexSubImage2DImmediate
 
 }  // namespace gles2
 }  // namespace gpu