Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2751543002: Revert of Split LivenessService out from LibCrosService. (Closed)

Created:
3 years, 9 months ago by teravest
Modified:
3 years, 9 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, hashimoto+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Split LivenessService out from LibCrosService. (patchset #3 id:40001 of https://codereview.chromium.org/2741803005/ ) Reason for revert: Another ChromeOS change has to land which grants permissions to this name. Original issue's description: > Split LivenessService out from LibCrosService. > > This is part of a larger effort to split LibCrosService into smaller > services for mus+ash. > > I've added a TODO to remove the old service once we've migrated > clients over to call the new one. > > BUG=692246 > > Review-Url: https://codereview.chromium.org/2741803005 > Cr-Commit-Position: refs/heads/master@{#456411} > Committed: https://chromium.googlesource.com/chromium/src/+/074cfdfc2e36001a72f2e2dfbcd7cc91819221e4 TBR=derat@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=692246 Review-Url: https://codereview.chromium.org/2751543002 Cr-Commit-Position: refs/heads/master@{#456499} Committed: https://chromium.googlesource.com/chromium/src/+/7d5e4125a792e09524a5942e829f2cfe738aa253

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -26 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 4 chunks +1 line, -14 lines 0 comments Download
M chromeos/dbus/services/liveness_service_provider.h View 3 chunks +4 lines, -8 lines 0 comments Download
M chromeos/dbus/services/liveness_service_provider.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
teravest
Created Revert of Split LivenessService out from LibCrosService.
3 years, 9 months ago (2017-03-13 21:43:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751543002/1
3 years, 9 months ago (2017-03-13 21:44:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/7d5e4125a792e09524a5942e829f2cfe738aa253
3 years, 9 months ago (2017-03-13 21:46:30 UTC) #6
Daniel Erat
3 years, 9 months ago (2017-03-13 23:05:23 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698