Split LivenessService out from LibCrosService.

Split LivenessService out from LibCrosService.

This is part of a larger effort to split LibCrosService into smaller
services for mus+ash.

I've added a TODO to remove the old service once we've migrated
clients over to call the new one.

BUG=692246
Review-Url: https://codereview.chromium.org/2741803005
Cr-Commit-Position: refs/heads/master@{#456411}
Committed: https://chromium.googlesource.com/chromium/src/+/074cfdfc2e36001a72f2e2dfbcd7cc91819221e4

[teravest, 2017-03-10 22:52:38]

The CQ bit was checked by teravest@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 22:53:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 23:33:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 23:33:17]

Dry run: This issue passed the CQ dry run.

[teravest, 2017-03-11 00:08:00]

Description was changed from

==========
Split LivenessService out from LibCrosService.

This is part of a larger effort to split LibCrosService into smaller
services for mus+ash.

I've added a TODO to remove the old service once we've migrated
clients over to call the new one.

BUG=692246
==========

to

==========
Split LivenessService out from LibCrosService.

This is part of a larger effort to split LibCrosService into smaller
services for mus+ash.

I've added a TODO to remove the old service once we've migrated
clients over to call the new one.

BUG=692246
==========

[teravest, 2017-03-11 00:08:01]

teravest@chromium.org changed reviewers:
+ derat@chromium.org

[Daniel Erat, 2017-03-11 01:27:42]

thanks! lgtm with a few comments.

https://codereview.chromium.org/2741803005/diff/1/chromeos/dbus/services/live...
File chromeos/dbus/services/liveness_service_provider.h (right):

https://codereview.chromium.org/2741803005/diff/1/chromeos/dbus/services/live...
chromeos/dbus/services/liveness_service_provider.h:39: explicit
LivenessServiceProvider(const char* service_interface);
const std::string& ?

i'd also add a TODO to remove this once we're not creating two of them.

https://codereview.chromium.org/2741803005/diff/1/chromeos/dbus/services/live...
chromeos/dbus/services/liveness_service_provider.h:56: const char*
service_interface_;
std::string?

[teravest, 2017-03-13 15:36:54]

The CQ bit was checked by teravest@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 15:37:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[teravest, 2017-03-13 16:02:28]

Thanks. Old C habits die hard.

https://codereview.chromium.org/2741803005/diff/1/chromeos/dbus/services/live...
File chromeos/dbus/services/liveness_service_provider.h (right):

https://codereview.chromium.org/2741803005/diff/1/chromeos/dbus/services/live...
chromeos/dbus/services/liveness_service_provider.h:39: explicit
LivenessServiceProvider(const char* service_interface);
On 2017/03/11 01:27:42, Daniel Erat wrote:
> const std::string& ?
> 
> i'd also add a TODO to remove this once we're not creating two of them.

Done.

https://codereview.chromium.org/2741803005/diff/1/chromeos/dbus/services/live...
chromeos/dbus/services/liveness_service_provider.h:56: const char*
service_interface_;
On 2017/03/11 01:27:42, Daniel Erat wrote:
> std::string?

Done.

[Daniel Erat, 2017-03-13 16:23:00]

lgtm

https://codereview.chromium.org/2741803005/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right):

https://codereview.chromium.org/2741803005/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/chrome_browser_main_chromeos.cc:331:
std::unique_ptr<CrosDBusService> liveness_service_;
nit: add a blank line above this line to separate it from the comment about
LibCrosService

[teravest, 2017-03-13 16:26:05]

https://codereview.chromium.org/2741803005/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (right):

https://codereview.chromium.org/2741803005/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/chrome_browser_main_chromeos.cc:331:
std::unique_ptr<CrosDBusService> liveness_service_;
On 2017/03/13 16:22:59, Daniel Erat wrote:
> nit: add a blank line above this line to separate it from the comment about
> LibCrosService

Done.

[teravest, 2017-03-13 16:26:11]

The CQ bit was checked by teravest@chromium.org

[teravest, 2017-03-13 16:26:11]

The patchset sent to the CQ was uploaded after l-g-t-m from derat@chromium.org
Link to the patchset: https://codereview.chromium.org/2741803005/#ps40001
(title: "Add blank line above liveness_service_")

[commit-bot: I haz the power, 2017-03-13 16:26:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 17:17:52]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489422371223320,
"parent_rev": "c70f051abea94357bd54bb6aae68e32387f8c737", "commit_rev":
"074cfdfc2e36001a72f2e2dfbcd7cc91819221e4"}

[commit-bot: I haz the power, 2017-03-13 17:18:38]

Description was changed from

==========
Split LivenessService out from LibCrosService.

This is part of a larger effort to split LibCrosService into smaller
services for mus+ash.

I've added a TODO to remove the old service once we've migrated
clients over to call the new one.

BUG=692246
==========

to

==========
Split LivenessService out from LibCrosService.

This is part of a larger effort to split LibCrosService into smaller
services for mus+ash.

I've added a TODO to remove the old service once we've migrated
clients over to call the new one.

BUG=692246

Review-Url: https://codereview.chromium.org/2741803005
Cr-Commit-Position: refs/heads/master@{#456411}
Committed:
https://chromium.googlesource.com/chromium/src/+/074cfdfc2e36001a72f2e2dfbcd7...
==========

[commit-bot: I haz the power, 2017-03-13 17:18:38]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/074cfdfc2e36001a72f2e2dfbcd7...

[Khushal, 2017-03-13 17:52:56]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2742343004/ by khushalsagar@chromium.org.

The reason for reverting is: Speculative revert for failing downstream bots:
https://bugs.chromium.org/p/chromium/issues/detail?id=700986.

[teravest, 2017-03-13 21:43:50]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2751543002/ by teravest@chromium.org.

The reason for reverting is: Another ChromeOS change has to land which grants
permissions to this name..