Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 2751523010: cros: Fix hotrod remote arrow keys not working on gaia for CFM oobe (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months ago by Qiang(Joe) Xu
Modified:
2 months ago
Reviewers:
xiyuan, Dan Beam
CC:
chromium-reviews, alemate+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Fix hotrod remote arrow keys not working on gaia for CFM oobe Changes: Regression comes from https://codereview.chromium.org/2586113002. keyboard_utils.js is also used in gaia content script, so that it doesn't have access to ui/webui/resources/js/util.js. Do not use hasKeyModifiers(event) in keyboard_utils.js. Adding NOPRESUBMIT=true because otherwise it will report document.getElementById('oauth-enroll-auth-view')) javascript style violation error. BUG=702674 NOPRESUBMIT=true TEST=test that it works now CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2751523010 Cr-Commit-Position: refs/heads/master@{#457929} Committed: https://chromium.googlesource.com/chromium/src/+/652e402f4703bf20297438b059d75c6884ba0d1f

Patch Set 1 #

Messages

Total messages: 16 (9 generated)
Qiang(Joe) Xu
Hi all, PTAL, thanks!
2 months ago (2017-03-17 18:48:19 UTC) #5
Dan Beam
lgtm i guess but duplicating code is a mild bummer
2 months ago (2017-03-17 18:51:33 UTC) #6
xiyuan
lgtm
2 months ago (2017-03-17 20:21:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751523010/1
2 months ago (2017-03-17 20:22:58 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/330927) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
2 months ago (2017-03-17 22:00:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751523010/1
2 months ago (2017-03-17 22:46:16 UTC) #13
commit-bot: I haz the power
2 months ago (2017-03-18 02:22:32 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/652e402f4703bf20297438b059d7...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06