cros: Fix hotrod remote arrow keys not working on gaia for CFM oobe

cros: Fix hotrod remote arrow keys not working on gaia for CFM oobe

Changes:
Regression comes from https://codereview.chromium.org/2586113002.
keyboard_utils.js is also used in gaia content script, so that it doesn't have access to ui/webui/resources/js/util.js. Do not use hasKeyModifiers(event) in keyboard_utils.js.

Adding NOPRESUBMIT=true because otherwise it will report document.getElementById('oauth-enroll-auth-view')) javascript style violation error.

BUG=702674
NOPRESUBMIT=true
TEST=test that it works now
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2751523010
Cr-Commit-Position: refs/heads/master@{#457929}
Committed: https://chromium.googlesource.com/chromium/src/+/652e402f4703bf20297438b059d75c6884ba0d1f

[Qiang(Joe) Xu, 2017-03-17 18:43:28]

Description was changed from

==========
cros: Fix hotrod remote arrow keys not working on gaia for CFM oobe

BUG=702674
TEST=test that it works now
==========

to

==========
cros: Fix hotrod remote arrow keys not working on gaia for CFM oobe

BUG=702674
TEST=test that it works now
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Qiang(Joe) Xu, 2017-03-17 18:46:23]

Description was changed from

==========
cros: Fix hotrod remote arrow keys not working on gaia for CFM oobe

BUG=702674
TEST=test that it works now
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: Fix hotrod remote arrow keys not working on gaia for CFM oobe

Changes:
Regression comes from https://codereview.chromium.org/2586113002.
keyboard_utils.js is also used in gaia content script, so that it doesn't have
access to ui/webui/resources/js/util.js. Do not use hasKeyModifiers(event) in
keyboard_utils.js.

BUG=702674
TEST=test that it works now
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Qiang(Joe) Xu, 2017-03-17 18:46:24]

warx@chromium.org changed reviewers:
+ dbeam@chromium.org, xiyuan@chromium.org

[Qiang(Joe) Xu, 2017-03-17 18:47:58]

Description was changed from

==========
cros: Fix hotrod remote arrow keys not working on gaia for CFM oobe

Changes:
Regression comes from https://codereview.chromium.org/2586113002.
keyboard_utils.js is also used in gaia content script, so that it doesn't have
access to ui/webui/resources/js/util.js. Do not use hasKeyModifiers(event) in
keyboard_utils.js.

BUG=702674
TEST=test that it works now
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: Fix hotrod remote arrow keys not working on gaia for CFM oobe

Changes:
Regression comes from https://codereview.chromium.org/2586113002.
keyboard_utils.js is also used in gaia content script, so that it doesn't have
access to ui/webui/resources/js/util.js. Do not use hasKeyModifiers(event) in
keyboard_utils.js.

Adding NOPRESUBMIT=true because otherwise it will report
document.getElementById('oauth-enroll-auth-view')) javascript style violation
error.

BUG=702674
NOPRESUBMIT=true
TEST=test that it works now
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Qiang(Joe) Xu, 2017-03-17 18:48:19]

Hi all, PTAL, thanks!

[Dan Beam, 2017-03-17 18:51:33]

lgtm i guess but duplicating code is a mild bummer

[xiyuan, 2017-03-17 20:21:59]

lgtm

[Qiang(Joe) Xu, 2017-03-17 20:22:34]

The CQ bit was checked by warx@chromium.org

[commit-bot: I haz the power, 2017-03-17 20:22:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 22:00:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 22:00:17]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Qiang(Joe) Xu, 2017-03-17 22:45:16]

The CQ bit was checked by warx@chromium.org

[commit-bot: I haz the power, 2017-03-17 22:46:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 02:21:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489790716805490, "parent_rev":
"5b49d1384ce8d1a8594bdb49f9f392da784b43bf", "commit_rev":
"652e402f4703bf20297438b059d75c6884ba0d1f"}

[commit-bot: I haz the power, 2017-03-18 02:22:31]

Description was changed from

==========
cros: Fix hotrod remote arrow keys not working on gaia for CFM oobe

Changes:
Regression comes from https://codereview.chromium.org/2586113002.
keyboard_utils.js is also used in gaia content script, so that it doesn't have
access to ui/webui/resources/js/util.js. Do not use hasKeyModifiers(event) in
keyboard_utils.js.

Adding NOPRESUBMIT=true because otherwise it will report
document.getElementById('oauth-enroll-auth-view')) javascript style violation
error.

BUG=702674
NOPRESUBMIT=true
TEST=test that it works now
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: Fix hotrod remote arrow keys not working on gaia for CFM oobe

Changes:
Regression comes from https://codereview.chromium.org/2586113002.
keyboard_utils.js is also used in gaia content script, so that it doesn't have
access to ui/webui/resources/js/util.js. Do not use hasKeyModifiers(event) in
keyboard_utils.js.

Adding NOPRESUBMIT=true because otherwise it will report
document.getElementById('oauth-enroll-auth-view')) javascript style violation
error.

BUG=702674
NOPRESUBMIT=true
TEST=test that it works now
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2751523010
Cr-Commit-Position: refs/heads/master@{#457929}
Committed:
https://chromium.googlesource.com/chromium/src/+/652e402f4703bf20297438b059d7...
==========

[commit-bot: I haz the power, 2017-03-18 02:22:32]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/652e402f4703bf20297438b059d7...