Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2751503002: Revert of Add a window property to associate RWHVA with its child AX tree ID (Closed)

Created:
3 years, 9 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
David Tseng, dmazzoni, jam, sky
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, tfarina, aboxhall+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, jam, nektar+watch_chromium.org, yuzo+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, James Su
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a window property to associate RWHVA with its child AX tree ID (patchset #4 id:60001 of https://codereview.chromium.org/2742533003/ ) Reason for revert: It looks like this causes the (static initializers) sizes step to fail: https://luci-milo.appspot.com/buildbot/chromium/Linux%20x64/35021 Original issue's description: > Add a window property to associate RWHVA with its child AX tree ID > > Working on making the Chrome OS virtual keyboard accessible to select-to-speak > and other accessibility services. Currently we link a views::WebView to its > inner web accessibility tree, but the VK just puts a WebContents directly in > an aura Window. > > This change hooks them up by adding the child AX tree ID as a window property. > > BUG=699617 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2742533003 > Cr-Commit-Position: refs/heads/master@{#456445} > Committed: https://chromium.googlesource.com/chromium/src/+/05107990b575defc12ba29da8ae17a8660a29b67 TBR=sky@chromium.org,dtseng@chromium.org,jam@chromium.org,dmazzoni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=699617 Review-Url: https://codereview.chromium.org/2751503002 Cr-Commit-Position: refs/heads/master@{#456479} Committed: https://chromium.googlesource.com/chromium/src/+/4a204455d3793edd5b016c99225df4241c928237

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -63 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 2 chunks +1 line, -2 lines 0 comments Download
M ui/accessibility/BUILD.gn View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/accessibility/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/accessibility/platform/aura_window_properties.h View 1 chunk +0 lines, -19 lines 0 comments Download
D ui/accessibility/platform/aura_window_properties.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M ui/views/accessibility/ax_window_obj_wrapper.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
qyearsley
Created Revert of Add a window property to associate RWHVA with its child AX tree ...
3 years, 9 months ago (2017-03-13 20:44:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751503002/1
3 years, 9 months ago (2017-03-13 20:45:22 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 21:06:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4a204455d3793edd5b016c99225d...

Powered by Google App Engine
This is Rietveld 408576698