Add a window property to associate RWHVA with its child AX tree ID

Add a window property to associate RWHVA with its child AX tree ID

Working on making the Chrome OS virtual keyboard accessible to select-to-speak
and other accessibility services. Currently we link a views::WebView to its
inner web accessibility tree, but the VK just puts a WebContents directly in
an aura Window.

This change hooks them up by adding the child AX tree ID as a window property.

BUG=699617
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2742533003
Cr-Commit-Position: refs/heads/master@{#456445}
Committed: https://chromium.googlesource.com/chromium/src/+/05107990b575defc12ba29da8ae17a8660a29b67

[dmazzoni, 2017-03-08 23:33:51]

Description was changed from

==========
Add a window property to associate RWHVA with its child AX tree ID

Working on making the Chrome OS virtual keyboard accessible to select-to-speak
and other accessibility services. Currently we link a views::WebView to its
inner web accessibility tree, but the VK just puts a WebContents directly in
an aura Window.

This change hooks them up by adding the child AX tree ID as a window property.

BUG=699617
==========

to

==========
Add a window property to associate RWHVA with its child AX tree ID

Working on making the Chrome OS virtual keyboard accessible to select-to-speak
and other accessibility services. Currently we link a views::WebView to its
inner web accessibility tree, but the VK just puts a WebContents directly in
an aura Window.

This change hooks them up by adding the child AX tree ID as a window property.

BUG=699617
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[dmazzoni, 2017-03-08 23:37:55]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org, sky@chromium.org

[sky, 2017-03-08 23:51:13]

https://codereview.chromium.org/2742533003/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_base.h (right):

https://codereview.chromium.org/2742533003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_base.h:214: virtual void
UpdateAXTreeID(ui::AXTreeIDRegistry::AXTreeID id) {}
SetMainFrameAXTreeID ?

[dmazzoni, 2017-03-09 00:18:19]

https://codereview.chromium.org/2742533003/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_base.h (right):

https://codereview.chromium.org/2742533003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_base.h:214: virtual void
UpdateAXTreeID(ui::AXTreeIDRegistry::AXTreeID id) {}
On 2017/03/08 23:51:12, sky wrote:
> SetMainFrameAXTreeID ?

Sure, done

[dmazzoni, 2017-03-09 00:18:22]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 00:20:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 00:28:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 00:28:27]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sky, 2017-03-09 01:04:44]

LGTM

https://codereview.chromium.org/2742533003/diff/20001/content/browser/frame_h...
File content/browser/frame_host/render_frame_host_impl.cc (right):

https://codereview.chromium.org/2742533003/diff/20001/content/browser/frame_h...
content/browser/frame_host/render_frame_host_impl.cc:1972:
view->UpdateAXTreeID(GetAXTreeID());
SetMainFrameAXTreeID

[dmazzoni, 2017-03-10 21:37:56]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2017-03-10 21:37:56]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2742533003/#ps40001
(title: "Fix call to SetMainFrameAXTreeID")

[commit-bot: I haz the power, 2017-03-10 21:38:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 21:43:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 21:43:42]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2017-03-10 21:47:09]

https://codereview.chromium.org/2742533003/diff/20001/content/browser/frame_h...
File content/browser/frame_host/render_frame_host_impl.cc (right):

https://codereview.chromium.org/2742533003/diff/20001/content/browser/frame_h...
content/browser/frame_host/render_frame_host_impl.cc:1972:
view->UpdateAXTreeID(GetAXTreeID());
On 2017/03/09 01:04:44, sky wrote:
> SetMainFrameAXTreeID

Done.

[dmazzoni, 2017-03-10 21:49:15]

dmazzoni@chromium.org changed reviewers:
+ jam@chromium.org

[dmazzoni, 2017-03-10 21:49:16]

+jam for content/

[jam, 2017-03-13 17:06:23]

lgtm

[dmazzoni, 2017-03-13 17:18:23]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2017-03-13 17:18:23]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2742533003/#ps60001
(title: "Fix deps")

[commit-bot: I haz the power, 2017-03-13 17:18:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 18:44:21]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489425503125330,
"parent_rev": "c57eaf40e82246d8acb9f58a350ef1a619cb19b1", "commit_rev":
"05107990b575defc12ba29da8ae17a8660a29b67"}

[commit-bot: I haz the power, 2017-03-13 18:45:13]

Description was changed from

==========
Add a window property to associate RWHVA with its child AX tree ID

Working on making the Chrome OS virtual keyboard accessible to select-to-speak
and other accessibility services. Currently we link a views::WebView to its
inner web accessibility tree, but the VK just puts a WebContents directly in
an aura Window.

This change hooks them up by adding the child AX tree ID as a window property.

BUG=699617
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Add a window property to associate RWHVA with its child AX tree ID

Working on making the Chrome OS virtual keyboard accessible to select-to-speak
and other accessibility services. Currently we link a views::WebView to its
inner web accessibility tree, but the VK just puts a WebContents directly in
an aura Window.

This change hooks them up by adding the child AX tree ID as a window property.

BUG=699617
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2742533003
Cr-Commit-Position: refs/heads/master@{#456445}
Committed:
https://chromium.googlesource.com/chromium/src/+/05107990b575defc12ba29da8ae1...
==========

[commit-bot: I haz the power, 2017-03-13 18:45:15]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/05107990b575defc12ba29da8ae1...

[qyearsley, 2017-03-13 20:44:35]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2751503002/ by qyearsley@chromium.org.

The reason for reverting is: It looks like this causes the (static initializers)
sizes step to fail:

https://luci-milo.appspot.com/buildbot/chromium/Linux%20x64/35021.