Chromium Code Reviews
DescriptionRevert of [Cronet] Write effective experimental options to NetLog (patchset #5 id:80001 of https://codereview.chromium.org/2738813004/ )
Reason for revert:
The bot
Android Cronet Builder Asan
is reporting
Failed steps failed cronet_unittests failed cronet_test_instrumentation_apk
I suspect this patch might be why.
https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Cronet%20Builder%20Asan/builds/1791
Original issue's description:
> [Cronet] Write effective experimental options to NetLog
>
> This CL does the following:
> (1) Have a warning in Experimental Options parsing code if there is an
> unrecognized option.
> (2) Make cronet_url_request_context_adapter use the new FileNetLogObserver which
> allows writing polled data.
> (3) Put the effective experimental options in the polled data.
>
> BUG=584806, 699567
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
>
> Review-Url: https://codereview.chromium.org/2738813004
> Cr-Commit-Position: refs/heads/master@{#457158}
> Committed: https://chromium.googlesource.com/chromium/src/+/3c275e0a2333511ec831b3c396dc9f38a161a8c6
TBR=kapishnikov@chromium.org,mgersh@chromium.org,xunjieli@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=584806, 699567
Review-Url: https://codereview.chromium.org/2751113004
Cr-Commit-Position: refs/heads/master@{#457408}
Committed: https://chromium.googlesource.com/chromium/src/+/2e20ab7ecb1ffe0fc6ece1e5c57c14b8ce1ec01f
Patch Set 1 #Messages
Total messages: 12 (6 generated)
|