Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2751113004: Revert of [Cronet] Write effective experimental options to NetLog (Closed)

Created:
3 years, 9 months ago by cblume
Modified:
3 years, 9 months ago
CC:
agrieve+watch_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Cronet] Write effective experimental options to NetLog (patchset #5 id:80001 of https://codereview.chromium.org/2738813004/ ) Reason for revert: The bot Android Cronet Builder Asan is reporting Failed steps failed cronet_unittests failed cronet_test_instrumentation_apk I suspect this patch might be why. https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Cronet%20Builder%20Asan/builds/1791 Original issue's description: > [Cronet] Write effective experimental options to NetLog > > This CL does the following: > (1) Have a warning in Experimental Options parsing code if there is an > unrecognized option. > (2) Make cronet_url_request_context_adapter use the new FileNetLogObserver which > allows writing polled data. > (3) Put the effective experimental options in the polled data. > > BUG=584806, 699567 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester > > Review-Url: https://codereview.chromium.org/2738813004 > Cr-Commit-Position: refs/heads/master@{#457158} > Committed: https://chromium.googlesource.com/chromium/src/+/3c275e0a2333511ec831b3c396dc9f38a161a8c6 TBR=kapishnikov@chromium.org,mgersh@chromium.org,xunjieli@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=584806, 699567 Review-Url: https://codereview.chromium.org/2751113004 Cr-Commit-Position: refs/heads/master@{#457408} Committed: https://chromium.googlesource.com/chromium/src/+/2e20ab7ecb1ffe0fc6ece1e5c57c14b8ce1ec01f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -306 lines) Patch
M components/cronet/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/cronet/android/cronet_url_request_context_adapter.h View 5 chunks +15 lines, -15 lines 0 comments Download
M components/cronet/android/cronet_url_request_context_adapter.cc View 9 chunks +40 lines, -55 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java View 4 chunks +14 lines, -0 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/ExperimentalOptionsTest.java View 1 chunk +0 lines, -44 lines 0 comments Download
M components/cronet/url_request_context_config.h View 3 chunks +1 line, -5 lines 0 comments Download
M components/cronet/url_request_context_config.cc View 6 chunks +153 lines, -183 lines 0 comments Download
M components/cronet/url_request_context_config_unittest.cc View 3 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
cblume
Created Revert of [Cronet] Write effective experimental options to NetLog
3 years, 9 months ago (2017-03-16 05:14:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751113004/1
3 years, 9 months ago (2017-03-16 05:14:40 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 9 months ago (2017-03-16 05:14:41 UTC) #5
aelias_OOO_until_Jul13
lgtm
3 years, 9 months ago (2017-03-16 05:56:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751113004/1
3 years, 9 months ago (2017-03-16 12:43:05 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 12:44:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2e20ab7ecb1ffe0fc6ece1e5c57c...

Powered by Google App Engine
This is Rietveld 408576698