Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/ExperimentalOptionsTest.java

Issue 2751113004: Revert of [Cronet] Write effective experimental options to NetLog (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/ExperimentalOptionsTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/ExperimentalOptionsTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/ExperimentalOptionsTest.java
index 53479648c50408f209e9c80c0fe9a9c61ad4181d..165f83c2141d26332aa646a4d26d4e4b033d8ff4 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/ExperimentalOptionsTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/ExperimentalOptionsTest.java
@@ -46,50 +46,6 @@
@SmallTest
@Feature({"Cronet"})
@OnlyRunNativeCronet
- // Tests that NetLog writes effective experimental options to NetLog.
- public void testNetLog() throws Exception {
- File directory = new File(PathUtils.getDataDirectory());
- File logfile = File.createTempFile("cronet", "json", directory);
- JSONObject hostResolverParams = CronetTestUtil.generateHostResolverRules();
- JSONObject experimentalOptions =
- new JSONObject().put("HostResolverRules", hostResolverParams);
- mBuilder.setExperimentalOptions(experimentalOptions.toString());
-
- mTestFramework = new CronetTestFramework(null, null, getContext(), mBuilder);
- mTestFramework.mCronetEngine.startNetLogToFile(logfile.getPath(), false);
- String url = Http2TestServer.getEchoMethodUrl();
- TestUrlRequestCallback callback = new TestUrlRequestCallback();
- UrlRequest.Builder builder = mTestFramework.mCronetEngine.newUrlRequestBuilder(
- url, callback, callback.getExecutor());
- UrlRequest urlRequest = builder.build();
- urlRequest.start();
- callback.blockForDone();
- assertEquals(200, callback.mResponseInfo.getHttpStatusCode());
- assertEquals("GET", callback.mResponseAsString);
- mTestFramework.mCronetEngine.stopNetLog();
- assertTrue(logfile.exists());
- assertTrue(logfile.length() != 0);
- BufferedReader logReader = new BufferedReader(new FileReader(logfile));
- boolean validFile = false;
- try {
- String logLine;
- while ((logLine = logReader.readLine()) != null) {
- if (logLine.contains("HostResolverRules")) {
- validFile = true;
- break;
- }
- }
- } finally {
- logReader.close();
- }
- assertTrue(validFile);
- assertTrue(logfile.delete());
- assertTrue(!logfile.exists());
- }
-
- @SmallTest
- @Feature({"Cronet"})
- @OnlyRunNativeCronet
public void testSetSSLKeyLogFile() throws Exception {
String url = Http2TestServer.getEchoMethodUrl();
File dir = new File(PathUtils.getDataDirectory());

Powered by Google App Engine
This is Rietveld 408576698