Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2751103004: Revert of Move ui/gfx/codec/ into its own component. (Closed)

Created:
3 years, 9 months ago by chrishtr
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move ui/gfx/codec/ into its own component. (patchset #7 id:120001 of https://codereview.chromium.org/2755563002/ ) Reason for revert: Breaks a chromeos unittest. Original issue's description: > Move ui/gfx/codec/ into its own component. > > This is necessary to break an include cycle between cc and ui/gfx/ for upcoming > changes to cc/paint/. > > TBR=robertphillips@google.com > > BUG=665259 > > Review-Url: https://codereview.chromium.org/2755563002 > Cr-Commit-Position: refs/heads/master@{#457238} > Committed: https://chromium.googlesource.com/chromium/src/+/e3d8f58563aececeeaa395795e022ddadf23c93d TBR=rockot@chromium.org,sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=665259 Review-Url: https://codereview.chromium.org/2751103004 Cr-Commit-Position: refs/heads/master@{#457281} Committed: https://chromium.googlesource.com/chromium/src/+/bcbe35fea06bbec5c83edaa74c1dae1bf8f7861d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+549 lines, -602 lines) Patch
M services/image_decoder/image_decoder_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/BUILD.gn View 7 chunks +26 lines, -2 lines 0 comments Download
A ui/gfx/chromeos/codec/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A ui/gfx/chromeos/codec/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A ui/gfx/chromeos/codec/jpeg_codec_robust_slow.h View 1 chunk +56 lines, -0 lines 0 comments Download
A ui/gfx/chromeos/codec/jpeg_codec_robust_slow.cc View 1 chunk +343 lines, -0 lines 0 comments Download
A ui/gfx/chromeos/codec/jpeg_codec_robust_slow_unittest.cc View 1 chunk +108 lines, -0 lines 0 comments Download
D ui/gfx/codec/BUILD.gn View 1 chunk +0 lines, -51 lines 0 comments Download
D ui/gfx/codec/chromeos/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D ui/gfx/codec/chromeos/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D ui/gfx/codec/chromeos/jpeg_codec_robust_slow.h View 1 chunk +0 lines, -59 lines 0 comments Download
D ui/gfx/codec/chromeos/jpeg_codec_robust_slow.cc View 1 chunk +0 lines, -341 lines 0 comments Download
D ui/gfx/codec/chromeos/jpeg_codec_robust_slow_unittest.cc View 1 chunk +0 lines, -104 lines 0 comments Download
D ui/gfx/codec/codec_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
M ui/gfx/codec/jpeg_codec.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/codec/png_codec.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/codec/skia_image_encoder_adapter.h View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
chrishtr
Created Revert of Move ui/gfx/codec/ into its own component.
3 years, 9 months ago (2017-03-16 00:17:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751103004/1
3 years, 9 months ago (2017-03-16 00:18:44 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 00:27:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bcbe35fea06bbec5c83edaa74c1d...

Powered by Google App Engine
This is Rietveld 408576698