pkg/kernel/lib/binary/ast_to_binary.dart - Issue 2751083002: Revert "[kernel] offsets on direct property get/set"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/kernel/lib/binary/ast_to_binary.dart

Issue 2751083002: Revert "[kernel] offsets on direct property get/set" (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/kernel/lib/binary/ast_to_binary.dart

diff --git a/pkg/kernel/lib/binary/ast_to_binary.dart b/pkg/kernel/lib/binary/ast_to_binary.dart

index fe26084476835ccc0a7681111e7a0211b5e16016..7ba49eef30d54176e7fe9902cf06e410ecc141fa 100644

--- a/pkg/kernel/lib/binary/ast_to_binary.dart

+++ b/pkg/kernel/lib/binary/ast_to_binary.dart

@@ -501,14 +501,12 @@ class BinaryPrinter extends Visitor {

visitDirectPropertyGet(DirectPropertyGet node) {

writeByte(Tag.DirectPropertyGet);

- writeOffset(node, node.fileOffset);

writeNode(node.receiver);

writeReference(node.targetReference);

}

visitDirectPropertySet(DirectPropertySet node) {

writeByte(Tag.DirectPropertySet);

- writeOffset(node, node.fileOffset);

writeNode(node.receiver);

writeReference(node.targetReference);

writeNode(node.value);