Issue 27510009: Files.app: Remove support for chrome://files.

Issue 27510009: Files.app: Remove support for chrome://files. (Closed)

Created:
7 years, 2 months ago by hirono

Modified:
7 years, 2 months ago

Reviewers:
mtomasz, benwells, satorux1

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Files.app: Remove support for chrome://files. Files.app has supported chrome://files URL, but it is no longer needed. This CL removes the support and the related tests. BUG=288447 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229598

Patch Set 1 #

Patch Set 2 : quit #

Patch Set 3 : Rebased. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -79 lines)			Patch
M	chrome/browser/chromeos/file_manager/url_util.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_url_rewrite_browsertest.cc	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View	1 2	2 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/util.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/file_manager/manifest.json	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc	View		1 chunk	+0 lines, -25 lines	0 comments	Download
M	chrome/common/extensions/manifest_url_handler.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/common/url_constants.h	View		2 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/common/url_constants.cc	View		2 chunks	+0 lines, -8 lines	0 comments	Download
D	chrome/test/data/extensions/browsertest/url_rewrite/file_manager/files.html	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	chrome/test/data/extensions/browsertest/url_rewrite/file_manager/manifest.json	View		1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

benwells

On 2013/10/17 05:26:28, hirono wrote: > PTAL the CL? Thanks! c/b/e/extension_url_rewrite_browsertest.cc and c/c/e/manifest_url_handler.cc lgtm. Let ...

7 years, 2 months ago (2013-10-17 05:34:48 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/27510009/3001

7 years, 2 months ago (2013-10-18 04:42:59 UTC) #5

commit-bot: I haz the power

Failed to trigger a try job on ios_dbg_simulator HTTP Error 400: Bad Request

7 years, 2 months ago (2013-10-18 16:53:48 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/27510009/53001

7 years, 2 months ago (2013-10-18 16:54:07 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/27510009/53001

7 years, 2 months ago (2013-10-18 21:40:56 UTC) #8

Message was sent while issue was closed.

Change committed as 229598

Expand Messages | Collapse Messages