Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7053)

Unified Diff: chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc

Issue 27510009: Files.app: Remove support for chrome://files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc
diff --git a/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc b/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc
index 6e926f787583687ce3064de77b6251670bf97c51..1ce1ac70da61c164787660e2607798819c84226f 100644
--- a/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc
+++ b/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc
@@ -149,29 +149,4 @@ TEST_F(FileBrowserHandlerManifestTest, ValidFileBrowserHandlerWithCreate) {
EXPECT_FALSE(action->CanWrite());
}
-TEST_F(FileBrowserHandlerManifestTest, FileManagerURLOverride) {
- scoped_ptr<DictionaryValue> manifest_value =
- DictionaryBuilder()
- .Set("name", "override_files")
- .Set("version", "1.0.0")
- .Set("manifest_version", 2)
- .Set("chrome_url_overrides", DictionaryBuilder()
- .Set("files", "main.html"))
- .Build();
-
- // Non component extensions can't override chrome://files/ URL.
- LoadAndExpectError(Manifest(manifest_value.get(), "override_files"),
- errors::kInvalidChromeURLOverrides);
-
- // A component extension can override chrome://files/ URL.
- std::string error;
- LoadExtension(Manifest(manifest_value.get(), "override_files"),
- &error, extensions::Manifest::COMPONENT, Extension::NO_FLAGS);
-#if defined(FILE_MANAGER_EXTENSION)
- EXPECT_EQ("", error);
-#else
- EXPECT_EQ(std::string(errors::kInvalidChromeURLOverrides), error);
-#endif
-}
-
} // namespace
« no previous file with comments | « chrome/browser/resources/file_manager/manifest.json ('k') | chrome/common/extensions/manifest_url_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698