[css-align] Adapt content-alignment properties to the new baseline syntax

[css-align] Adapt content-alignment properties to the new baseline syntax

The baseline-position syntax has changed recently, so we need to update
the CSS properties using the old syntax. This patch address only the
content-alignment (align-content and justify-content).

I used this patch to adapt the implementation of the parsing logic for
these properties to the new Blink's CSS Parsing Design.

The new baseline syntax is "[first | last ]? baseline" which implies
modifying the parsing and computed value logic.

There are several layout tests affected by this change, so I'll update
them accordingly.

BUG=565883
Review-Url: https://codereview.chromium.org/2750843002
Cr-Commit-Position: refs/heads/master@{#457434}
Committed: https://chromium.googlesource.com/chromium/src/+/81ac6e10b85aa327c1e26799807da952a7b930d8

[jfernandez, 2017-03-14 14:17:08]

Description was changed from

==========
[css-align] Adapt content-alignment properties to the new baseline syntax

The baseline-position syntax has changed recently, so we need to update
the CSS properties using the old syntax. This patch address only the
content-alignment (align-content and justify-content).

I used this patch to adapt the implementation of the parsing logic for
these properties to the new Blink's CSS Parsing Design.

The new baseline syntax is "[first | last ]? baseline" which implies
modifying the parsing and computed value logic.

There are several layout tests affected by this change, so I'll update
them accordingly.

BUG=565883
==========

to

==========
[css-align] Adapt content-alignment properties to the new baseline syntax

The baseline-position syntax has changed recently, so we need to update
the CSS properties using the old syntax. This patch address only the
content-alignment (align-content and justify-content).

I used this patch to adapt the implementation of the parsing logic for
these properties to the new Blink's CSS Parsing Design.

The new baseline syntax is "[first | last ]? baseline" which implies
modifying the parsing and computed value logic.

There are several layout tests affected by this change, so I'll update
them accordingly.

BUG=565883
==========

[jfernandez, 2017-03-14 14:17:08]

jfernandez@igalia.com changed reviewers:
+ meade@chromium.org, rego@igalia.com, svillar@igalia.com

[jfernandez, 2017-03-14 14:25:59]

Patch ready for review.

[meade_UTC10, 2017-03-15 05:50:46]

lgtm

This looks great, and thanks for moving stuff to the new CSSPropertyAPI format!
Added Sasha+Bugs to cc as FYI.

[jfernandez, 2017-03-15 08:36:40]

The CQ bit was checked by jfernandez@igalia.com

[commit-bot: I haz the power, 2017-03-15 08:36:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 08:42:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 08:42:12]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jfernandez, 2017-03-16 12:59:30]

The CQ bit was checked by jfernandez@igalia.com

[jfernandez, 2017-03-16 12:59:30]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org
Link to the patchset: https://codereview.chromium.org/2750843002/#ps20001
(title: "Don't use raw pointers attributes on a GC managed class.")

[commit-bot: I haz the power, 2017-03-16 12:59:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 15:03:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489669170445890,
"parent_rev": "873b27d518038be94df98d1128a2e8047e0ef942", "commit_rev":
"81ac6e10b85aa327c1e26799807da952a7b930d8"}

[commit-bot: I haz the power, 2017-03-16 15:04:25]

Description was changed from

==========
[css-align] Adapt content-alignment properties to the new baseline syntax

The baseline-position syntax has changed recently, so we need to update
the CSS properties using the old syntax. This patch address only the
content-alignment (align-content and justify-content).

I used this patch to adapt the implementation of the parsing logic for
these properties to the new Blink's CSS Parsing Design.

The new baseline syntax is "[first | last ]? baseline" which implies
modifying the parsing and computed value logic.

There are several layout tests affected by this change, so I'll update
them accordingly.

BUG=565883
==========

to

==========
[css-align] Adapt content-alignment properties to the new baseline syntax

The baseline-position syntax has changed recently, so we need to update
the CSS properties using the old syntax. This patch address only the
content-alignment (align-content and justify-content).

I used this patch to adapt the implementation of the parsing logic for
these properties to the new Blink's CSS Parsing Design.

The new baseline syntax is "[first | last ]? baseline" which implies
modifying the parsing and computed value logic.

There are several layout tests affected by this change, so I'll update
them accordingly.

BUG=565883

Review-Url: https://codereview.chromium.org/2750843002
Cr-Commit-Position: refs/heads/master@{#457434}
Committed:
https://chromium.googlesource.com/chromium/src/+/81ac6e10b85aa327c1e26799807d...
==========

[commit-bot: I haz the power, 2017-03-16 15:04:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/81ac6e10b85aa327c1e26799807d...