Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: third_party/WebKit/Source/core/css/CSSContentDistributionValue.cpp

Issue 2750843002: [css-align] Adapt content-alignment properties to the new baseline syntax (Closed)
Patch Set: Don't use raw pointers attributes on a GC managed class. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSContentDistributionValue.cpp
diff --git a/third_party/WebKit/Source/core/css/CSSContentDistributionValue.cpp b/third_party/WebKit/Source/core/css/CSSContentDistributionValue.cpp
index 7b04ac0152fdc110c123dbc0f194fb5f82a36de4..ee7c4bcdd9bdbab2d4f03aeb750a4763d570a4f9 100644
--- a/third_party/WebKit/Source/core/css/CSSContentDistributionValue.cpp
+++ b/third_party/WebKit/Source/core/css/CSSContentDistributionValue.cpp
@@ -25,8 +25,17 @@ String CSSContentDistributionValue::customCSSText() const {
if (m_distribution != CSSValueInvalid)
list->append(*distribution());
- if (m_position != CSSValueInvalid)
- list->append(*position());
+ if (m_position != CSSValueInvalid) {
+ if (m_position == CSSValueFirstBaseline ||
+ m_position == CSSValueLastBaseline) {
+ CSSValueID preference =
+ m_position == CSSValueFirstBaseline ? CSSValueFirst : CSSValueLast;
+ list->append(*CSSIdentifierValue::create(preference));
+ list->append(*CSSIdentifierValue::create(CSSValueBaseline));
+ } else {
+ list->append(*position());
+ }
+ }
if (m_overflow != CSSValueInvalid)
list->append(*overflow());

Powered by Google App Engine
This is Rietveld 408576698