[json] improve output to get leak_to and better logging.

[json] improve output to get leak_to and better logging.

This adds the 'leak_to' parameter to json.output, and also makes it so
that when logging is enabled and the json is invalid, the raw data is
written to the json log instead (for easier debugging).

R=dnj@chromium.org, phajdan.jr@chromium.org, tikuta@chromium.org, vadimsh@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2750793002
Committed: https://github.com/luci/recipes-py/commit/9fdd6d725d8d04125d43ce2be4f5e4b123f705be

[tikuta1, 2017-03-14 09:55:31]

tikuta@google.com changed reviewers:
+ tikuta@google.com

[tikuta1, 2017-03-14 09:55:32]

https://codereview.chromium.org/2750793002/diff/1/recipe_modules/json/api.py
File recipe_modules/json/api.py (right):

https://codereview.chromium.org/2750793002/diff/1/recipe_modules/json/api.py#...
recipe_modules/json/api.py:18: temporary file (e.g. /tmp/tmp4lp1qM) which will
exist only for the duration of
Better to update comment near here?

[iannucci, 2017-03-14 10:02:01]

Is this comment more useful?

https://codereview.chromium.org/2750793002/diff/1/recipe_modules/json/api.py
File recipe_modules/json/api.py (right):

https://codereview.chromium.org/2750793002/diff/1/recipe_modules/json/api.py#...
recipe_modules/json/api.py:18: temporary file (e.g. /tmp/tmp4lp1qM) which will
exist only for the duration of
On 2017/03/14 09:55:31, tikuta1 wrote:
> Better to update comment near here?

Oh, wow, this comment is very out of date! I've fixed it.

[Paweł Hajdan Jr., 2017-03-14 12:56:14]

LGTM w/ optional suggestion.

https://codereview.chromium.org/2750793002/diff/20001/recipe_modules/json/api.py
File recipe_modules/json/api.py (right):

https://codereview.chromium.org/2750793002/diff/20001/recipe_modules/json/api...
recipe_modules/json/api.py:65: presentation.logs[self.label + ' (invalid)'] =
raw_data.splitlines()
Consider also capturing what the exception was and printing it here. Up to you /
could be a TODO.

[iannucci, 2017-03-14 17:34:53]

https://codereview.chromium.org/2750793002/diff/20001/recipe_modules/json/api.py
File recipe_modules/json/api.py (right):

https://codereview.chromium.org/2750793002/diff/20001/recipe_modules/json/api...
recipe_modules/json/api.py:65: presentation.logs[self.label + ' (invalid)'] =
raw_data.splitlines()
On 2017/03/14 12:56:14, Paweł Hajdan Jr. wrote:
> Consider also capturing what the exception was and printing it here. Up to you
/
> could be a TODO.

Done.

[iannucci, 2017-03-14 17:47:05]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2017-03-14 17:47:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/2750793002/#ps60001
(title: "add test assertion")

[commit-bot: I haz the power, 2017-03-14 17:47:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 17:53:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 17:53:47]

Try jobs failed on following builders:
  Recipes-py Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/34e6c01abe274e10)

[iannucci, 2017-03-14 18:58:33]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2017-03-14 18:58:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/2750793002/#ps80001
(title: "fixit")

[commit-bot: I haz the power, 2017-03-14 18:58:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 19:01:54]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489517913135730,
"parent_rev": "05a33f9dcf2289bbaf233fcae1e2fb508d95f528", "commit_rev":
"9fdd6d725d8d04125d43ce2be4f5e4b123f705be"}

[commit-bot: I haz the power, 2017-03-14 19:01:58]

Description was changed from

==========
[json] improve output to get leak_to and better logging.

This adds the 'leak_to' parameter to json.output, and also makes it so
that when logging is enabled and the json is invalid, the raw data is
written to the json log instead (for easier debugging).

R=dnj@chromium.org, phajdan.jr@chromium.org, tikuta@chromium.org,
vadimsh@chromium.org
BUG=
==========

to

==========
[json] improve output to get leak_to and better logging.

This adds the 'leak_to' parameter to json.output, and also makes it so
that when logging is enabled and the json is invalid, the raw data is
written to the json log instead (for easier debugging).

R=dnj@chromium.org, phajdan.jr@chromium.org, tikuta@chromium.org,
vadimsh@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2750793002
Committed:
https://github.com/luci/recipes-py/commit/9fdd6d725d8d04125d43ce2be4f5e4b123f...
==========

[commit-bot: I haz the power, 2017-03-14 19:01:59]

Committed patchset #5 (id:80001) as
https://github.com/luci/recipes-py/commit/9fdd6d725d8d04125d43ce2be4f5e4b123f...