Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: recipe_modules/json/example.expected/basic.json

Issue 2750793002: [json] improve output to get leak_to and better logging. (Closed)
Patch Set: fixit Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « recipe_modules/json/example.py ('k') | recipe_modules/json/example.resources/cool_script.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipe_modules/json/example.expected/basic.json
diff --git a/recipe_modules/json/example.expected/basic.json b/recipe_modules/json/example.expected/basic.json
index e2f14ae6fd9ca18654d1db0e87ef1541f677ba06..613adfac52c2641f99182bb20499182392c7cbaa 100644
--- a/recipe_modules/json/example.expected/basic.json
+++ b/recipe_modules/json/example.expected/basic.json
@@ -104,6 +104,38 @@
]
},
{
+ "cmd": [
+ "python",
+ "RECIPE[recipe_engine::json:example].resources/cool_script.py",
+ "{\"x\":1,\"y\":2}",
+ "[TMP_BASE]/leak.json"
+ ],
+ "name": "leaking json",
+ "~followup_annotations": [
+ "@@@STEP_LOG_LINE@json.output@{@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"x\": 1, @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"y\": 2@@@",
+ "@@@STEP_LOG_LINE@json.output@}@@@",
+ "@@@STEP_LOG_END@json.output@@@"
+ ]
+ },
+ {
+ "cmd": [
+ "python",
+ "RECIPE[recipe_engine::json:example].resources/cool_script.py",
+ "{\"here is some total\ngarbage",
+ "/path/to/tmp/json"
+ ],
+ "name": "invalid json",
+ "~followup_annotations": [
+ "@@@STEP_LOG_LINE@json.output (invalid)@{\"here is some total@@@",
+ "@@@STEP_LOG_LINE@json.output (invalid)@garbage@@@",
+ "@@@STEP_LOG_END@json.output (invalid)@@@",
+ "@@@STEP_LOG_LINE@json.output (exception)@Invalid control character at: line 1 column 21 (char 20)@@@",
+ "@@@STEP_LOG_END@json.output (exception)@@@"
+ ]
+ },
+ {
"name": "$result",
"recipe_result": null,
"status_code": 0
« no previous file with comments | « recipe_modules/json/example.py ('k') | recipe_modules/json/example.resources/cool_script.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698