Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2750703002: Add support for MD2, MD4, and MD5 to SignatureAlgorithm. (Closed)

Created:
3 years, 9 months ago by eroman
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Add support for MD2, MD4, and MD5 to SignatureAlgorithm. (At a parsing level it is useful to recognize these for error handling, even if in practice they aren't used when verifying signatures.) Review-Url: https://codereview.chromium.org/2728953003 Cr-Commit-Position: refs/heads/master@{#455350} (cherry picked from commit 37e84a0d658536248f4a4372551c36db2e614c1f) BUG=690821 Review-Url: https://codereview.chromium.org/2750703002 . Cr-Commit-Position: refs/branch-heads/3029@{#165} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/37ff2437dc0a3c4c0e6cf0976b1967bca2d5f057

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -11 lines) Patch
M net/cert/internal/parse_ocsp.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/cert/internal/signature_algorithm.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/cert/internal/signature_algorithm.cc View 3 chunks +25 lines, -0 lines 0 comments Download
M net/cert/internal/signature_algorithm_unittest.cc View 1 chunk +63 lines, -0 lines 0 comments Download
M net/cert/internal/signature_policy.cc View 1 chunk +41 lines, -1 line 0 comments Download
M net/cert/internal/verify_signed_data.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M net/cert/x509_util_openssl.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-intermediate-signed-with-md5.py View 1 chunk +2 lines, -2 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-target-signed-with-md5.py View 1 chunk +2 lines, -2 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/intermediate-signed-with-md5.pem View 1 chunk +3 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-signed-with-md5.pem View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
eroman
3 years, 9 months ago (2017-03-13 21:23:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
37ff2437dc0a3c4c0e6cf0976b1967bca2d5f057.

Powered by Google App Engine
This is Rietveld 408576698