Do not reload UI if the Reading List entry does not exist

Do not reload UI if the Reading List entry does not exist

The custom accessibility actions check for the existence of the ReadingListModel
entry when configuring a cell. This CL changes this behavior to do nothing when
the entry does not exist instead of reloading the UI.

BUG=676290, 701956
Review-Url: https://codereview.chromium.org/2750623006
Cr-Commit-Position: refs/heads/master@{#457382}
Committed: https://chromium.googlesource.com/chromium/src/+/a757a98d4a7f12ac9b53135dfd8e1452b5455920

[gambard, 2017-03-16 08:30:32]

gambard@chromium.org changed reviewers:
+ olivierrobin@chromium.org

[gambard, 2017-03-16 08:30:32]

PTAL.

[Olivier, 2017-03-16 08:41:33]

https://codereview.chromium.org/2750623006/diff/1/ios/chrome/browser/ui/readi...
File
ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
(left):

https://codereview.chromium.org/2750623006/diff/1/ios/chrome/browser/ui/readi...
ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm:699:
// The entry has been removed from the model, reload all data to synchronize
Does it mean we will keep the view desynchronized?

[gambard, 2017-03-16 08:56:30]

I have added an EG test.

https://codereview.chromium.org/2750623006/diff/1/ios/chrome/browser/ui/readi...
File
ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
(left):

https://codereview.chromium.org/2750623006/diff/1/ios/chrome/browser/ui/readi...
ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm:699:
// The entry has been removed from the model, reload all data to synchronize
On 2017/03/16 08:41:33, Olivier Robin wrote:
> Does it mean we will keep the view desynchronized?

Yes. This is only used by the custom accessibility actions.

[Olivier, 2017-03-16 09:02:37]

lgtm

[gambard, 2017-03-16 09:03:11]

The CQ bit was checked by gambard@chromium.org

[commit-bot: I haz the power, 2017-03-16 09:03:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 09:14:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489654991139430,
"parent_rev": "8552274ebe052e07472a852e37f6cbbe73bbecda", "commit_rev":
"a757a98d4a7f12ac9b53135dfd8e1452b5455920"}

[commit-bot: I haz the power, 2017-03-16 09:15:10]

Description was changed from

==========
Do not reload UI if the Reading List entry does not exist

The custom accessibility actions check for the existence of the ReadingListModel
entry when configuring a cell. This CL changes this behavior to do nothing when
the entry does not exist instead of reloading the UI.

BUG=676290, 701956
==========

to

==========
Do not reload UI if the Reading List entry does not exist

The custom accessibility actions check for the existence of the ReadingListModel
entry when configuring a cell. This CL changes this behavior to do nothing when
the entry does not exist instead of reloading the UI.

BUG=676290, 701956

Review-Url: https://codereview.chromium.org/2750623006
Cr-Commit-Position: refs/heads/master@{#457382}
Committed:
https://chromium.googlesource.com/chromium/src/+/a757a98d4a7f12ac9b53135dfd8e...
==========

[commit-bot: I haz the power, 2017-03-16 09:15:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a757a98d4a7f12ac9b53135dfd8e...