Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm

Issue 2750623006: Do not reload UI if the Reading List entry does not exist (Closed)
Patch Set: Add test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/ui/reading_list/reading_list_egtest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
diff --git a/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm b/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
index 45ddedcb46aa2cbe98740f295fb18d39eb02665a..731467f002d1020f911fa0457b4755e9a8afa24d 100644
--- a/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
+++ b/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
@@ -120,7 +120,7 @@ using ItemsMapByDate = std::multimap<int64_t, ReadingListCollectionViewItem*>;
// Stops observing the ReadingListModel.
- (void)stopObservingReadingListModel;
// Returns the ReadingListEntry associated with the |item|. If there is not such
-// an entry, returns nullptr and reloads the UI.
+// an entry, returns nullptr.
- (const ReadingListEntry*)readingListEntryForItem:
(ReadingListCollectionViewItem*)item;
// Updates the toolbar state according to the selected items.
@@ -695,12 +695,6 @@ using ItemsMapByDate = std::multimap<int64_t, ReadingListCollectionViewItem*>;
const ReadingListEntry* readingListEntry =
self.readingListModel->GetEntryByURL(item.url);
- if (!readingListEntry) {
- // The entry has been removed from the model, reload all data to synchronize
- // the UI with the model.
- [self reloadData];
- }
-
return readingListEntry;
}
« no previous file with comments | « no previous file | ios/chrome/browser/ui/reading_list/reading_list_egtest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698