Avoid unnecessary LocalSurfaceId allocation in RenderWidgetHostViewChildFrame/Guest

Since we are moving local surface id allocation to the renderer process,
frame eviction which is done by the browser process should not change
the local surface id. Also, RenderWidgetHostViewGuest should not
create a new local surface id when guest->has_attached_since_surface_set()
is true.

BUG=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2750623002
Cr-Commit-Position: refs/heads/master@{#456472}
Committed: https://chromium.googlesource.com/chromium/src/+/88f2781989652da5ac0ad9351353a46559224040

[Saman Sami, 2017-03-13 15:51:07]

Description was changed from

==========
RenderWidgetHostViewChildFrame/Guest should not reset LocalSurfaceId on frame
eviction

BUG=697864
==========

to

==========
RenderWidgetHostViewChildFrame/Guest should not reset LocalSurfaceId on frame
eviction

BUG=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-03-13 15:51:43]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 15:52:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 16:06:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 16:06:57]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Saman Sami, 2017-03-13 17:09:56]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 17:10:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-03-13 17:14:32]

Description was changed from

==========
RenderWidgetHostViewChildFrame/Guest should not reset LocalSurfaceId on frame
eviction

BUG=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
RenderWidgetHostViewChildFrame/Guest should not reset LocalSurfaceId on frame
eviction

Since we are moving local surface id allocation to the renderer process,
frame eviction which is done by the browser process should not change
the local surface id. Also, RenderWidgetHostViewChildGuest should not
create a new local surface id when guest->has_attached_since_surface_set()
is true.

BUG=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-03-13 17:15:49]

Description was changed from

==========
RenderWidgetHostViewChildFrame/Guest should not reset LocalSurfaceId on frame
eviction

Since we are moving local surface id allocation to the renderer process,
frame eviction which is done by the browser process should not change
the local surface id. Also, RenderWidgetHostViewChildGuest should not
create a new local surface id when guest->has_attached_since_surface_set()
is true.

BUG=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Since we are moving local surface id allocation to the renderer process,
frame eviction which is done by the browser process should not change
the local surface id. Also, RenderWidgetHostViewChildGuest should not
create a new local surface id when guest->has_attached_since_surface_set()
is true.

BUG=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-03-13 17:45:47]

Description was changed from

==========
Since we are moving local surface id allocation to the renderer process,
frame eviction which is done by the browser process should not change
the local surface id. Also, RenderWidgetHostViewChildGuest should not
create a new local surface id when guest->has_attached_since_surface_set()
is true.

BUG=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Since we are moving local surface id allocation to the renderer process,
frame eviction which is done by the browser process should not change
the local surface id. Also, RenderWidgetHostViewGuest should not
create a new local surface id when guest->has_attached_since_surface_set()
is true.

BUG=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Saman Sami, 2017-03-13 17:45:47]

samans@chromium.org changed reviewers:
+ piman@chromium.org

[Saman Sami, 2017-03-13 17:46:52]

PTAL

[piman, 2017-03-13 17:51:42]

LGTM. Would it make sense to add a test for the new behavior (something like:
get a new frame; get current local id; evict frame; get a new frame; check local
id is same as before).

[commit-bot: I haz the power, 2017-03-13 17:56:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 17:56:57]

Dry run: This issue passed the CQ dry run.

[Saman Sami, 2017-03-13 18:35:25]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 18:36:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-03-13 18:40:02]

On 2017/03/13 17:51:42, piman wrote:
> LGTM. Would it make sense to add a test for the new behavior (something like:
> get a new frame; get current local id; evict frame; get a new frame; check
local
> id is same as before).

Thanks for the lgtm! I added a test. Also the test in RWHVGuest covers the case
when has_attached_since_surface_set is set.

[Saman Sami, 2017-03-13 18:41:16]

The CQ bit was unchecked by samans@chromium.org

[Saman Sami, 2017-03-13 18:41:21]

The CQ bit was checked by samans@chromium.org

[Saman Sami, 2017-03-13 18:41:21]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2750623002/#ps40001
(title: "Added test")

[commit-bot: I haz the power, 2017-03-13 18:41:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2017-03-13 19:18:22]

LGTM, thanks for the test!

[commit-bot: I haz the power, 2017-03-13 20:43:11]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489430481345300,
"parent_rev": "066cc760621cc88821160743e4a2c5ac937cfd9a", "commit_rev":
"88f2781989652da5ac0ad9351353a46559224040"}

[commit-bot: I haz the power, 2017-03-13 20:43:51]

Description was changed from

==========
Since we are moving local surface id allocation to the renderer process,
frame eviction which is done by the browser process should not change
the local surface id. Also, RenderWidgetHostViewGuest should not
create a new local surface id when guest->has_attached_since_surface_set()
is true.

BUG=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Since we are moving local surface id allocation to the renderer process,
frame eviction which is done by the browser process should not change
the local surface id. Also, RenderWidgetHostViewGuest should not
create a new local surface id when guest->has_attached_since_surface_set()
is true.

BUG=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2750623002
Cr-Commit-Position: refs/heads/master@{#456472}
Committed:
https://chromium.googlesource.com/chromium/src/+/88f2781989652da5ac0ad9351353...
==========

[commit-bot: I haz the power, 2017-03-13 20:43:52]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/88f2781989652da5ac0ad9351353...